Uh oh!
There was an error while loading. Please reload this page.
test: checks on napi factory wrap’s finalization - #22612
Conversation
BridgeAR
commented
Aug 31, 2018
@nodejs/n-api PTAL |
gabrielschulhof
left a comment
There was a problem hiding this comment.
I'm actually not sure that we need this PR given that we already test for this in https://github.com/nodejs/node/blob/master/test/addons-napi/8_passing_wrapped/test.js.
gabrielschulhof
commented
Aug 31, 2018
Nevertheless, I don't have any strong objections to landing this. |
@legendecas I suppose for completeness you could instead, in https://github.com/nodejs/node/blob/master/test/addons-napi/8_passing_wrapped/test.js, change the storage of obj2=null;global.gc();assert.strictEqual(addon.finalizeCount(),2);That would round out that test nicely. |
legendecas
commented
Aug 31, 2018
@gabrielschulhof thanks for reviewing😁. amended. It's true that finalizer has been checked in 8_passing_wrapped, however it could be more reasonable to take more checks. |
gabrielschulhof
commented
Sep 4, 2018
gabrielschulhof
commented
Sep 4, 2018
Resumed CI as: https://ci.nodejs.org/job/node-test-pull-request/17016/ |
gabrielschulhof
commented
Sep 4, 2018
Resumed again as CI: https://ci.nodejs.org/job/node-test-pull-request/17017/ |
gabrielschulhof
commented
Sep 5, 2018
gabrielschulhof
commented
Sep 6, 2018
gabrielschulhof
commented
Sep 12, 2018
gabrielschulhof
commented
Sep 12, 2018
Another new CI: https://ci.nodejs.org/job/node-test-pull-request/17145/ |
gabrielschulhof
commented
Sep 12, 2018
Resumed CI as: https://ci.nodejs.org/job/node-test-pull-request/17152/ |
gabrielschulhof
commented
Sep 13, 2018
Landed in 1cee085. |
Expect closing #22396
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes