crypto: fix key requirements in asymmetric cipher

PR-URL: #30249Fixes: #30237
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: tniessen

lib/internal/crypto/cipher.js

@@ -66,11 +66,11 @@ function rsaFunctionFor(method, defaultPadding, keyType) {
 constpublicEncrypt=rsaFunctionFor(_publicEncrypt,RSA_PKCS1_OAEP_PADDING,
 'public');
 constpublicDecrypt=rsaFunctionFor(_publicDecrypt,RSA_PKCS1_PADDING,
-'private');
+'public');
 constprivateEncrypt=rsaFunctionFor(_privateEncrypt,RSA_PKCS1_PADDING,
 'private');
 constprivateDecrypt=rsaFunctionFor(_privateDecrypt,RSA_PKCS1_OAEP_PADDING,
-'public');
+'private');
 
 functiongetDecoder(decoder,encoding){
 encoding=normalizeEncoding(encoding);

test/parallel/test-crypto-key-objects.js

@@ -15,8 +15,10 @@ const {
  createPrivateKey,
  KeyObject,
  randomBytes,
+ publicDecrypt,
  publicEncrypt,
- privateDecrypt
+ privateDecrypt,
+ privateEncrypt
 }=require('crypto');
 
 constfixtures=require('../common/fixtures');
@@ -156,7 +158,16 @@ const privateDsa = fixtures.readKey('dsa_private_encrypted_1025.pem',
 assert(Buffer.isBuffer(privateDER));
 
 constplaintext=Buffer.from('Hello world','utf8');
-constciphertexts=[
+consttestDecryption=(fn,ciphertexts,decryptionKeys)=>{
+for(constciphertextofciphertexts){
+for(constkeyofdecryptionKeys){
+constdeciphered=fn(key,ciphertext);
+assert.deepStrictEqual(deciphered,plaintext);
+}
+}
+};
+
+testDecryption(privateDecrypt,[
 // Encrypt using the public key.
 publicEncrypt(publicKey,plaintext),
 publicEncrypt({key: publicKey},plaintext),
@@ -173,20 +184,25 @@ const privateDsa = fixtures.readKey('dsa_private_encrypted_1025.pem',
 // DER-encoded data only.
 publicEncrypt({format: 'der',type: 'pkcs1',key: publicDER},plaintext),
 publicEncrypt({format: 'der',type: 'pkcs1',key: privateDER},plaintext)
-];
-
-constdecryptionKeys=[
+],[
 privateKey,
 {format: 'pem',key: privatePem},
 {format: 'der',type: 'pkcs1',key: privateDER}
-];
+]);
 
-for(constciphertextofciphertexts){
-for(constkeyofdecryptionKeys){
-constdeciphered=privateDecrypt(key,ciphertext);
-assert(plaintext.equals(deciphered));
-}
-}
+testDecryption(publicDecrypt,[
+privateEncrypt(privateKey,plaintext)
+],[
+// Decrypt using the public key.
+publicKey,
+{format: 'pem',key: publicPem},
+{format: 'der',type: 'pkcs1',key: publicDER},
+
+// Decrypt using the private key.
+privateKey,
+{format: 'pem',key: privatePem},
+{format: 'der',type: 'pkcs1',key: privateDER}
+]);
 }
 
 {