Skip to content

crypto: fix key requirements in asymmetric cipher - #30249

Closed
tniessen wants to merge 2 commits into
nodejs:masterfrom
tniessen:crypto-fix-publicdecrypt
Closed

crypto: fix key requirements in asymmetric cipher#30249
tniessen wants to merge 2 commits into
nodejs:masterfrom
tniessen:crypto-fix-publicdecrypt

Conversation

@tniessen

@tniessentniessen commented Nov 4, 2019

Copy link
Copy Markdown
Member

Fixes: #30237

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@tniessentniessen added the crypto Issues and PRs related to the crypto subsystem. label Nov 4, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
bnoordhuis
bnoordhuis approved these changes Nov 4, 2019
View reviewed changes
Comment threadtest/parallel/test-crypto-key-objects.js Outdated
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Nov 4, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26336/

@bnoordhuisbnoordhuis mentioned this pull request Nov 5, 2019
Closed
tniessen added a commit that referenced this pull request Nov 13, 2019
@tniessen
crypto: fix key requirements in asymmetric cipher
78dbe74
PR-URL: #30249Fixes: #30237
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@tniessen

tniessen commented Nov 13, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in 78dbe74, thanks for reviewing!

MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
@tniessen@MylesBorins
crypto: fix key requirements in asymmetric cipher
39d0a25
PR-URL: #30249Fixes: #30237
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeARBridgeAR mentioned this pull request Nov 19, 2019
Merged
targos pushed a commit that referenced this pull request Dec 1, 2019
@tniessen@targos
crypto: fix key requirements in asymmetric cipher
be0b53d
PR-URL: #30249Fixes: #30237
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 9, 2019
Closed
BethGriggs added a commit that referenced this pull request Dec 9, 2019
@BethGriggs
2019-12-17, Version 12.13.2 'Erbium' (LTS)
d02ac1c
Notable changes:
- crypto: fix key requirements in asymmetric cipher (Tobias Nießen)
#30249
- deps:
- update llhttp to 2.0.1 (Fedor Indutny)
#30553
- upgrade npm to 6.13.1 (claudiahdz)
#30533
- update nghttp2 to 1.40.0 (gengjiawen)
#30493
- v8: mark serdes API as stable (Anna Henningsen)
#30234
PR-URL: #30865
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@tniessen@MylesBorins
crypto: fix key requirements in asymmetric cipher
bb7e78a
PR-URL: #30249Fixes: #30237
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 23, 2019
Merged
BethGriggs added a commit that referenced this pull request Dec 23, 2019
@BethGriggs
2020-01-07, Version 12.14.1 'Erbium' (LTS)
423b44a
Notable changes:
- crypto: fix key requirements in asymmetric cipher (Tobias Nießen)
#30249
- deps:
- update llhttp to 2.0.1 (Fedor Indutny)
#30553
- update nghttp2 to 1.40.0 (gengjiawen)
#30493
- v8: mark serdes API as stable (Anna Henningsen)
#30234
PR-URL: #31069
BethGriggs added a commit that referenced this pull request Dec 27, 2019
@BethGriggs
2020-01-07, Version 12.14.1 'Erbium' (LTS)
db01408
Notable changes:
- crypto: fix key requirements in asymmetric cipher (Tobias Nießen)
#30249
- deps:
- update llhttp to 2.0.1 (Fedor Indutny)
#30553
- update nghttp2 to 1.40.0 (gengjiawen)
#30493
- v8: mark serdes API as stable (Anna Henningsen)
#30234
PR-URL: #31069
BethGriggs added a commit that referenced this pull request Dec 31, 2019
@BethGriggs
2020-01-07, Version 12.14.1 'Erbium' (LTS)
9622fed
Notable changes:
- crypto: fix key requirements in asymmetric cipher (Tobias Nießen)
#30249
- deps:
- update llhttp to 2.0.1 (Fedor Indutny)
#30553
- update nghttp2 to 1.40.0 (gengjiawen)
#30493
- v8: mark serdes API as stable (Anna Henningsen)
#30234
PR-URL: #31069
BethGriggs added a commit that referenced this pull request Jan 7, 2020
@BethGriggs
2020-01-07, Version 12.14.1 'Erbium' (LTS)
f5512ff
Notable changes:
- crypto: fix key requirements in asymmetric cipher (Tobias Nießen)
#30249
- deps:
- update llhttp to 2.0.1 (Fedor Indutny)
#30553
- update nghttp2 to 1.40.0 (gengjiawen)
#30493
- v8: mark serdes API as stable (Anna Henningsen)
#30234
PR-URL: #31069
@tniessen
tniessen deleted the crypto-fix-publicdecrypt branch January 23, 2020 03:49
sda3211
sda3211 reviewed Jul 14, 2020
View reviewed changes

@sda3211sda3211 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#34283

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes
@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+1 more reviewer
@sda3211sda3211sda3211 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cryptoIssues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

crypto.publicDecrypt doesn't seem to work

7 participants

@tniessen@nodejs-github-bot@bnoordhuis@jasnell@cjihrig@BridgeAR@sda3211