worker: refactor to avoid unsafe array iteration

PR-URL: #36735
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: aduh95

lib/internal/worker.js

@@ -4,6 +4,7 @@
 
 const{
  ArrayIsArray,
+ ArrayPrototypeForEach,
  ArrayPrototypeMap,
  ArrayPrototypePush,
  Float64Array,
@@ -14,7 +15,9 @@ const {
  ObjectEntries,
  Promise,
  PromiseResolve,
+ ReflectApply,
  RegExpPrototypeTest,
+ SafeArrayIterator,
  String,
  Symbol,
  SymbolFor,
@@ -155,8 +158,10 @@ class Worker extends EventEmitter {
 letenv;
 if(typeofoptions.env==='object'&&options.env!==null){
 env=ObjectCreate(null);
-for(const[key,value]ofObjectEntries(options.env))
-env[key]=`${value}`;
+ArrayPrototypeForEach(
+ObjectEntries(options.env),
+({0: key,1: value})=>{env[key]=`${value}`;}
+);
 }elseif(options.env==null){
 env=process.env;
 }elseif(options.env!==SHARE_ENV){
@@ -209,12 +214,13 @@ class Worker extends EventEmitter {
 consttransferList=[port2];
 // If transferList is provided.
 if(options.transferList)
-ArrayPrototypePush(transferList, ...options.transferList);
+ArrayPrototypePush(transferList,
+ ...newSafeArrayIterator(options.transferList));
 
 this[kPublicPort]=port1;
-for(consteventof['message','messageerror']){
+ArrayPrototypeForEach(['message','messageerror'],(event)=>{
 this[kPublicPort].on(event,(message)=>this.emit(event,message));
-}
+});
 setupPortReferencing(this[kPublicPort],this,'message');
 this[kPort].postMessage({
  argv,
@@ -279,8 +285,9 @@ class Worker extends EventEmitter {
 {
 const{ stream, chunks }=message;
 constreadable=this[kParentSideStdio][stream];
-for(const{ chunk, encoding }ofchunks)
+ArrayPrototypeForEach(chunks,({ chunk, encoding })=>{
 readable.push(chunk,encoding);
+});
 return;
 }
 casemessageTypes.STDIO_WANTS_MORE_DATA:
@@ -314,7 +321,7 @@ class Worker extends EventEmitter {
 postMessage(...args){
 if(this[kPublicPort]===null)return;
 
-this[kPublicPort].postMessage(...args);
+ReflectApply(this[kPublicPort].postMessage,this[kPublicPort],args);
 }
 
 terminate(callback){