worker: refactor to avoid unsafe array iteration

[aduh95]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[aduh95]

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/854/ (queued, will 404 until it starts)

[aduh95]

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/854/ (queued, will 404 until it starts)

No perf improvements or regressions.

Details

 confidence improvement accuracy (*) (**) (***)
worker/atomics-wait.js n=10000000 1.04 % ±2.91% ±3.87% ±5.04%
worker/bench-eventlooputil.js method='ELU_passed' n=1000000 0.22 % ±2.25% ±2.99% ±3.89%
worker/bench-eventlooputil.js method='ELU_simple' n=1000000 -0.90 % ±2.30% ±3.06% ±3.98%
worker/echo.js n=100000 sendsPerBroadcast=10 payload='object' workers=1 2.86 % ±5.65% ±7.52% ±9.78%
worker/echo.js n=100000 sendsPerBroadcast=10 payload='string' workers=1 -0.66 % ±4.81% ±6.40% ±8.34%
worker/echo.js n=100000 sendsPerBroadcast=1 payload='object' workers=1 -2.49 % ±3.08% ±4.12% ±5.38%
worker/echo.js n=100000 sendsPerBroadcast=1 payload='string' workers=1 0.16 % ±3.32% ±4.42% ±5.76%
worker/messageport.js n=1000000 style='eventemitter' payload='object' 2.89 % ±3.42% ±4.57% ±5.98%
worker/messageport.js n=1000000 style='eventemitter' payload='string' 0.74 % ±3.30% ±4.42% ±5.83%
worker/messageport.js n=1000000 style='eventtarget' payload='object' 2.41 % ±2.81% ±3.75% ±4.89%
worker/messageport.js n=1000000 style='eventtarget' payload='string' 2.82 % ±4.47% ±5.99% ±7.89%
Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case there are 11 comparisons, you can thus
expect the following amount of false-positive results:
0.55 false positives, when considering a 5% risk acceptance (*, **, ***),
0.11 false positives, when considering a 1% risk acceptance (**, ***),
0.01 false positives, when considering a 0.1% risk acceptance (***)

[targos]

typo: woker -> worker

[aduh95]

typo: woker -> worker

Good catch! I'll fix that on/if landing if that's OK.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/35485/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/35495/

[aduh95]

Landed in 7c37e04