Skip to content

Commit c247153

Browse files
refackBridgeAR
authored andcommitted
build,win: simplify new msbuild_arg option
PR-URL: #26431 Refs: #25994 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 0a1537e commit c247153

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

‎vcbuild.bat‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ set no_cctest=
6363
setcctest=
6464
setopenssl_no_asm=
6565
setdoc=
66-
setextra_msbuild_args=^
66+
setextra_msbuild_args=
6767

6868
:next-arg
6969
if"%1"==""goto args-done
@@ -138,8 +138,7 @@ if /i "%1"=="no-cctest" set no_cctest=1&goto arg-ok
138138
if /i "%1"=="cctest"setcctest=1&goto arg-ok
139139
if /i "%1"=="openssl-no-asm"setopenssl_no_asm=1&goto arg-ok
140140
if /i "%1"=="doc"setdoc=1&goto arg-ok
141-
if /i "%1"=="binlog"setextra_msbuild_args=%extra_msbuild_args% /binaryLogger:%config%\node.binlog&goto arg-ok
142-
if /i "%1"=="msbuild_arg"setextra_msbuild_args=%extra_msbuild_args%%2&goto arg-ok-2
141+
if /i "%1"=="binlog"setextra_msbuild_args=/binaryLogger:%config%\node.binlog&goto arg-ok
143142

144143
echo Error: invalid command line option `%1`.
145144
exit /b 1
@@ -258,6 +257,7 @@ set vcvars_call="%VCINSTALLDIR%\Auxiliary\Build\vcvarsall.bat" %vcvarsall_arg%
258257
echo calling: %vcvars_call%
259258
call%vcvars_call%
260259
iferrorlevel1goto msbuild-not-found
260+
ifdefined DEBUG_HELPER @ECHOON
261261
:found_vs2017
262262
echo Found MSVS version %VisualStudioVersion%
263263
setGYP_MSVS_VERSION=2017
@@ -323,6 +323,7 @@ if "%target%"=="Build" (
323323
ifdefined cctest settarget="Build"
324324
)
325325
if"%target%"=="rename_node_bin_win"ifexist"%config%\cctest.exe"del"%config%\cctest.exe"
326+
ifdefined msbuild_args set"extra_msbuild_args=%extra_msbuild_args%%msbuild_args%"
326327
msbuild node.sln %msbcpu% /t:%target% /p:Configuration=%config% /p:Platform=%msbplatform% /clp:NoSummary;NoItemAndPropertyList;Verbosity=minimal /nologo %extra_msbuild_args%
327328
iferrorlevel1 (
328329
ifnotdefined project_generated echo Building Node with reused solution failed. To regenerate project files use "vcbuild projgen"

0 commit comments

Comments
 (0)