Skip to content

build,win: simplify new msbuild_arg option - #26431

Closed
refack wants to merge 1 commit into
nodejs:masterfrom
refack:tweak-vcbuld-change
Closed

build,win: simplify new msbuild_arg option#26431
refack wants to merge 1 commit into
nodejs:masterfrom
refack:tweak-vcbuld-change

Conversation

@refack

@refackrefack commented Mar 4, 2019

Copy link
Copy Markdown
Contributor

Make the mechanism of passing msbuild_args backwards compatible.
Refs: #25994

/CC @nodejs/build-files @nodejs/platform-windows

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Mar 4, 2019

Copy link
Copy Markdown
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2755/pipeline

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Mar 4, 2019
@refack

refack commented Mar 4, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Windows only CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/25157/
https://ci.nodejs.org/job/node-test-commit-windows-fanned/25158/

@refackrefack self-assigned this Mar 4, 2019
@refack
refackforce-pushed the tweak-vcbuld-change branch from 1e43eb0 to 0620d5dCompareMarch 4, 2019 16:30
@BridgeAR

BridgeAR commented Mar 5, 2019

Copy link
Copy Markdown
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21220/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 5, 2019
@BridgeAR

BridgeAR commented Mar 6, 2019

Copy link
Copy Markdown
Member

Landed in dfffb6d 🎉

@BridgeARBridgeAR closed this Mar 6, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 6, 2019
@refack@BridgeAR
build,win: simplify new msbuild_arg option
dfffb6d
PR-URL: nodejs#26431
Refs: nodejs#25994
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@refack

refack commented Mar 7, 2019

Copy link
Copy Markdown
ContributorAuthor

@BridgeAR I appreciate the intent to help 🙏, but I self-assigned this, as per the collaborator guide.
(In this case I wanted to follow up with changes and verification in our CI setup)

@refack
refack deleted the tweak-vcbuld-change branch March 7, 2019 14:37
@refackrefack added landed and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 7, 2019
@refackrefack removed their assignment Mar 7, 2019
@BridgeAR

BridgeAR commented Mar 7, 2019

Copy link
Copy Markdown
Member

@refack I was not aware of that change. It is the first time that anything like that came up for me. Isn't it possible to follow up with the changes and verification now?
I am somewhat confused by this rule.

@BridgeAR

BridgeAR commented Mar 7, 2019

Copy link
Copy Markdown
Member

I would rather have a PR marked as WIP if it should not yet land.

@refack

refack commented Mar 7, 2019

Copy link
Copy Markdown
ContributorAuthor

I was not aware of that change.

Understood. No harm done.

I am somewhat confused by this rule.

There was a bit of discussion around it. The idea is to allow Collaborators to indicate they wish to land their PRs on their own.

I would rather have a PR marked as WIP if it should not yet land.

The problem with that is that PRs marked with WIP do not get reviewed 🤷‍♂️

I totally understand that in a big project like node, it complicated to balance concerns like velocity, manageability, and individual preferences.

@richardlau

richardlau commented Mar 7, 2019

Copy link
Copy Markdown
Member

Maybe git-node land in node-core-utils could check if a PR is self-assigned and warn if so?

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
@refack@BridgeAR
build,win: simplify new msbuild_arg option
3dd7084
PR-URL: nodejs#26431
Refs: nodejs#25994
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeARBridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@refack@BridgeAR
build,win: simplify new msbuild_arg option
c247153
PR-URL: #26431
Refs: #25994
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@richardlaurichardlaurichardlau approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+1 more reviewer
@joaocgreisjoaocgreisjoaocgreis approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.windowsIssues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@refack@nodejs-github-bot@BridgeAR@richardlau@joaocgreis@jasnell