dns: refactor to use more primordials

PR-URL: #36314
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Author: aduh95

lib/dns.js

@@ -22,9 +22,11 @@
 'use strict';
 
 const{
+ ArrayPrototypeMap,
  ObjectCreate,
  ObjectDefineProperties,
  ObjectDefineProperty,
+ ReflectApply,
 }=primordials;
 
 constcares=internalBinding('cares_wrap');
@@ -197,7 +199,8 @@ ObjectDefineProperty(lookupService, customPromisifyArgs,
 
 functiononresolve(err,result,ttls){
 if(ttls&&this.ttl)
-result=result.map((address,index)=>({ address,ttl: ttls[index]}));
+result=ArrayPrototypeMap(
+result,(address,index)=>({ address,ttl: ttls[index]}));
 
 if(err)
 this.callback(dnsException(err,this.bindingName,this.hostname));
@@ -261,7 +264,7 @@ function resolve(hostname, rrtype, callback) {
 }
 
 if(typeofresolver==='function'){
-returnresolver.call(this,hostname,callback);
+returnReflectApply(resolver,this,[hostname,callback]);
 }
 thrownewERR_INVALID_OPT_VALUE('rrtype',rrtype);
 }

lib/internal/dns/promises.js

@@ -1,9 +1,11 @@
 'use strict';
 
 const{
+ ArrayPrototypeMap,
  ObjectCreate,
  ObjectDefineProperty,
  Promise,
+ ReflectApply,
 }=primordials;
 
 const{
@@ -169,7 +171,8 @@ function onresolve(err, result, ttls) {
 }
 
 if(ttls&&this.ttl)
-result=result.map((address,index)=>({ address,ttl: ttls[index]}));
+result=ArrayPrototypeMap(
+result,(address,index)=>({ address,ttl: ttls[index]}));
 
 this.resolve(result);
 }
@@ -246,7 +249,7 @@ Resolver.prototype.resolve = function resolve(hostname, rrtype) {
 thrownewERR_INVALID_ARG_TYPE('rrtype','string',rrtype);
 }
 
-returnresolver.call(this,hostname);
+returnReflectApply(resolver,this,[hostname]);
 };
 
 

lib/internal/dns/utils.js

@@ -2,8 +2,13 @@
 
 const{
  ArrayIsArray,
+ ArrayPrototypeForEach,
+ ArrayPrototypeJoin,
+ ArrayPrototypeMap,
  ArrayPrototypePush,
+ FunctionPrototypeBind,
  NumberParseInt,
+ StringPrototypeMatch,
  StringPrototypeReplace,
 }=primordials;
 
@@ -45,7 +50,7 @@ class Resolver {
 }
 
 getServers(){
-returnthis._handle.getServers().map((val)=>{
+returnArrayPrototypeMap(this._handle.getServers(),(val)=>{
 if(!val[1]||val[1]===IANA_DNS_PORT)
 returnval[0];
 
@@ -65,16 +70,16 @@ class Resolver {
 constorig=this._handle.getServers();
 constnewSet=[];
 
-servers.forEach((serv,index)=>{
+ArrayPrototypeForEach(servers,(serv,index)=>{
 if(typeofserv!=='string'){
 thrownewERR_INVALID_ARG_TYPE(`servers[${index}]`,'string',serv);
 }
 letipVersion=isIP(serv);
 
 if(ipVersion!==0)
-returnnewSet.push([ipVersion,serv,IANA_DNS_PORT]);
+returnArrayPrototypePush(newSet,[ipVersion,serv,IANA_DNS_PORT]);
 
-constmatch=serv.match(IPv6RE);
+constmatch=StringPrototypeMatch(serv,IPv6RE);
 
 // Check for an IPv6 in brackets.
 if(match){
@@ -88,7 +93,7 @@ class Resolver {
 }
 
 // addr::port
-constaddrSplitMatch=serv.match(addrSplitRE);
+constaddrSplitMatch=StringPrototypeMatch(serv,addrSplitRE);
 
 if(addrSplitMatch){
 consthostIP=addrSplitMatch[1];
@@ -109,7 +114,7 @@ class Resolver {
 
 if(errorNumber!==0){
 // Reset the servers to the old servers, because ares probably unset them.
-this._handle.setServers(orig.join(','));
+this._handle.setServers(ArrayPrototypeJoin(orig,','));
 consterr=strerror(errorNumber);
 thrownewERR_DNS_SET_SERVERS_FAILED(err,servers);
 }
@@ -156,8 +161,8 @@ function setDefaultResolver(resolver) {
 }
 
 functionbindDefaultResolver(target,source){
-resolverKeys.forEach((key)=>{
-target[key]=source[key].bind(defaultResolver);
+ArrayPrototypeForEach(resolverKeys,(key)=>{
+target[key]=FunctionPrototypeBind(source[key],defaultResolver);
 });
 }