Skip to content

dns: refactor to use more primordials - #36314

Closed
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:dns-primordials
Closed

dns: refactor to use more primordials#36314
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:dns-primordials

Conversation

@aduh95

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the dns Issues and PRs related to the dns subsystem. label Nov 29, 2020
@aduh95aduh95 added the needs-benchmark-ci PR that need a benchmark CI run. label Nov 29, 2020
@aduh95

This comment has been minimized.

@aduh95

aduh95 commented Dec 1, 2020

Copy link
Copy Markdown
ContributorAuthor

Benchmark CI didn't show any perf regression or improvement.

Details
 confidence improvement accuracy (*) (**) (***)
dns/lookup.js n=5000000 all='false' name='::1' 1.68 % ±2.48% ±3.30% ±4.29%
dns/lookup.js n=5000000 all='false' name='127.0.0.1' -2.53 % ±5.59% ±7.46% ±9.76%
dns/lookup.js n=5000000 all='true' name='::1' 0.05 % ±2.09% ±2.79% ±3.63%
dns/lookup.js n=5000000 all='true' name='127.0.0.1' -2.49 % ±4.02% ±5.36% ±7.00%
dns/lookup-promises.js n=5000000 all='false' name='::1' 12.40 % ±16.94% ±22.79% ±30.16%
dns/lookup-promises.js n=5000000 all='false' name='127.0.0.1' 0.95 % ±3.04% ±4.04% ±5.26%
dns/lookup-promises.js n=5000000 all='true' name='::1' 5.62 % ±9.65% ±12.97% ±17.15%
dns/lookup-promises.js n=5000000 all='true' name='127.0.0.1' 0.88 % ±4.24% ±5.64% ±7.35%
Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case there are 8 comparisons, you can thus
expect the following amount of false-positive results:
0.40 false positives, when considering a 5% risk acceptance (*, **, ***),
0.08 false positives, when considering a 1% risk acceptance (**, ***),
0.01 false positives, when considering a 0.1% risk acceptance (***)

@aduh95aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-benchmark-ci PR that need a benchmark CI run. labels Dec 1, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 1, 2020
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 2, 2020
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 2, 2020
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 7, 2020
@Trott

Trott commented Dec 7, 2020

Copy link
Copy Markdown
Member

@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 7, 2020
@github-actionsgithub-actionsBot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 7, 2020
@github-actions

Copy link
Copy Markdown
Contributor

Landed in bf31d3c...96b4950

nodejs-github-bot pushed a commit that referenced this pull request Dec 7, 2020
PR-URL: #36314
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95
aduh95 deleted the dns-primordials branch December 7, 2020 19:41
targos pushed a commit that referenced this pull request Dec 21, 2020
PR-URL: #36314
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targostargos mentioned this pull request Dec 22, 2020
targos pushed a commit that referenced this pull request May 16, 2021
PR-URL: #36314
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targostargos mentioned this pull request Jun 6, 2021
targos pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #36314
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.dnsIssues and PRs related to the dns subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95@nodejs-github-bot@Trott@targos