fs: fix nonNativeWatcher leak of StatWatchers

PR-URL: #45501
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Author: MoLow

lib/internal/fs/recursive_watch.js

@@ -154,14 +154,11 @@ class FSWatcher extends EventEmitter {
 this.#symbolicFiles.add(f);
 }
 
+this.#files.set(f,file);
 if(file.isFile()){
 this.#watchFile(f);
-}else{
-this.#files.set(f,file);
-
-if(file.isDirectory()&&!file.isSymbolicLink()){
-awaitthis.#watchFolder(f);
-}
+}elseif(file.isDirectory()&&!file.isSymbolicLink()){
+awaitthis.#watchFolder(f);
 }
 }
 }

test/parallel/test-fs-watch-recursive.js

@@ -213,6 +213,33 @@ tmpdir.refresh();
 });
 })().then(common.mustCall());
 
+
+(async()=>{
+// Assert recursive watch does not leak handles
+constrootDirectory=fs.mkdtempSync(testDir+path.sep);
+consttestDirectory=path.join(rootDirectory,'test-7');
+constfilePath=path.join(testDirectory,'only-file.txt');
+fs.mkdirSync(testDirectory);
+
+letwatcherClosed=false;
+constwatcher=fs.watch(testDirectory,{recursive: true});
+watcher.on('change',common.mustCallAtLeast(async(event,filename)=>{
+awaitsetTimeout(common.platformTimeout(100));
+if(filename===path.basename(filePath)){
+watcher.close();
+watcherClosed=true;
+}
+awaitsetTimeout(common.platformTimeout(100));
+assert(!process._getActiveHandles().some((handle)=>handle.constructor.name==='StatWatcher'));
+}));
+
+process.on('exit',function(){
+assert(watcherClosed,'watcher Object was not closed');
+});
+awaitsetTimeout(common.platformTimeout(100));
+fs.writeFileSync(filePath,'content');
+})().then(common.mustCall());
+
 (async()=>{
 // Handle non-boolean values for options.recursive