Skip to content

fs: fix nonNativeWatcher leak of StatWatchers - #45501

Merged
MoLow merged 1 commit into
nodejs:mainfrom
MoLow:fix-recursive-watch-leak
Nov 27, 2022
Merged

fs: fix nonNativeWatcher leak of StatWatchers#45501
MoLow merged 1 commit into
nodejs:mainfrom
MoLow:fix-recursive-watch-leak

Conversation

@MoLow

@MoLowMoLow commented Nov 17, 2022

Copy link
Copy Markdown
Member

a simple reproduction was added as a test

@MoLow
MoLow requested a review from anonrigNovember 17, 2022 22:27
@nodejs-github-botnodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Nov 17, 2022
@MoLow

MoLow commented Nov 17, 2022

Copy link
Copy Markdown
MemberAuthor

CC @nodejs/fs

LiviaMedeiros
LiviaMedeiros reviewed Nov 18, 2022
View reviewed changes
Comment threadlib/internal/fs/recursive_watch.js Outdated
anonrig
anonrig requested changes Nov 18, 2022
View reviewed changes
Comment threadtest/parallel/test-fs-watch-recursive.js Outdated
Comment threadtest/parallel/test-fs-watch-recursive.js Outdated
Comment threadtest/parallel/test-fs-watch-recursive.js Outdated
anonrig
anonrig reviewed Nov 18, 2022
View reviewed changes
Comment threadlib/internal/fs/recursive_watch.js Outdated
@MoLow
MoLow requested a review from anonrigNovember 25, 2022 07:28
@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 25, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 25, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48189/

@github-actionsgithub-actionsBot mentioned this pull request Nov 26, 2022
Open
21 tasks
@MoLowMoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 26, 2022
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 26, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 26, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48198/

@nodejs-github-bot

nodejs-github-bot commented Nov 26, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48201/

@github-actionsgithub-actionsBot mentioned this pull request Nov 27, 2022
Open
21 tasks
@MoLowMoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2022
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 27, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 27, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/45501
✔ Done loading data for nodejs/node/pull/45501
----------------------------------- PR info ------------------------------------
Title fs: fix `nonNativeWatcher` leak of `StatWatchers` (#45501)
Author Moshe Atlow (@MoLow)
Branch MoLow:fix-recursive-watch-leak -> nodejs:main
Labels fs, author ready, needs-ci, commit-queue-squash
Commits 6
- fs: fix `nonNativeWatcher` leak of `StatWatchers`
- Lint
- fix
- CR
- CR
- fix
Committers 1
- Moshe Atlow PR-URL: https://github.com/nodejs/node/pull/45501
Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45501
Reviewed-By: Yagiz Nizipli --------------------------------------------------------------------------------
⚠ Commits were pushed since the last review:
⚠ - fix
ℹ This PR was created on Thu, 17 Nov 2022 22:27:07 GMT
✔ Approvals: 1
✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45501#pullrequestreview-1194715945
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2022-11-26T22:27:48Z: https://ci.nodejs.org/job/node-test-pull-request/48201/
- Querying data for job/node-test-pull-request/48201/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3557422926

@MoLow
fs: fix nonNativeWatcher leak of StatWatchers
b9fbd1c
PR-URL: nodejs#45501
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@MoLow
MoLowforce-pushed the fix-recursive-watch-leak branch from 665c6f9 to b9fbd1cCompareNovember 27, 2022 08:39
@MoLow
MoLow merged commit b9fbd1c into nodejs:mainNov 27, 2022
@MoLow

MoLow commented Nov 27, 2022

Copy link
Copy Markdown
MemberAuthor

Landed in b9fbd1c

@MoLow
MoLow deleted the fix-recursive-watch-leak branch November 27, 2022 08:40
@github-actionsgithub-actionsBot mentioned this pull request Nov 28, 2022
Open
20 tasks
This was referenced Nov 29, 2022
Open
Open
This was referenced Dec 1, 2022
Open
Open
Open
Open
Open
targos pushed a commit that referenced this pull request Dec 12, 2022
@MoLow@targos
fs: fix nonNativeWatcher leak of StatWatchers
d272faa
PR-URL: #45501
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@targostargos mentioned this pull request Dec 12, 2022
Merged
@danielleadamsdanielleadams mentioned this pull request Dec 30, 2022
Merged
@danielleadams

danielleadams commented Dec 30, 2022

Copy link
Copy Markdown
Contributor

Hey @MoLow, the test couldn't be pulled into v18.x-staging. Do you mind creating a backport PR? Thanks!

@MoLowMoLow mentioned this pull request Dec 31, 2022
Closed
@MoLowMoLow added backport-open-v18.x and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. backport-requested-v18.x labels Dec 31, 2022
MoLow added a commit to MoLow/node that referenced this pull request Jan 5, 2023
@MoLow
fs: fix nonNativeWatcher leak of StatWatchers
1c6772a
PR-URL: nodejs#45501
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LiviaMedeirosLiviaMedeirosLiviaMedeiros left review comments
@anonriganonriganonrig approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.fsIssues and PRs related to the fs subsystem / file system.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MoLow@nodejs-github-bot@danielleadams@anonrig@LiviaMedeiros