benchmark: use let instead of var in crypto

dnlup · targos · commit d30911e51b36 · 2020-01-14T08:30:44.000+01:00
PR-URL: #31135 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/benchmark/crypto/aes-gcm-throughput.js b/benchmark/crypto/aes-gcm-throughput.js
@@ -25,7 +25,7 @@ function AEAD_Bench(cipher, message, associate_data, key, iv, n, len) {
 const bits = written * 8;
 const mbits = bits / (1024 * 1024);
 
- for (var i = 0; i < n; i++) {
+ for (let i = 0; i < n; i++) {
 const alice = crypto.createCipheriv(cipher, key, iv);
 alice.setAAD(associate_data);
 const enc = alice.update(message);
diff --git a/benchmark/crypto/cipher-stream.js b/benchmark/crypto/cipher-stream.js
@@ -38,8 +38,8 @@ function main({ api, cipher, type, len, writes }) {
 const alice_cipher = crypto.createCipher(cipher, alice_secret);
 const bob_cipher = crypto.createDecipher(cipher, bob_secret);
 
- var message;
- var encoding;
+ let message;
+ let encoding;
 switch (type) {
 case 'asc':
 message = 'a'.repeat(len);
@@ -65,7 +65,7 @@ function main({ api, cipher, type, len, writes }) {
 }
 
 function streamWrite(alice, bob, message, encoding, writes) {
- var written = 0;
+ let written = 0;
 bob.on('data', (c) => {
 written += c.length;
 });
@@ -86,9 +86,9 @@ function streamWrite(alice, bob, message, encoding, writes) {
 }
 
 function legacyWrite(alice, bob, message, encoding, writes) {
- var written = 0;
- var enc, dec;
- for (var i = 0; i < writes; i++) {
+ let written = 0;
+ let enc, dec;
+ for (let i = 0; i < writes; i++) {
 enc = alice.update(message, encoding);
 dec = bob.update(enc);
 written += dec.length;
diff --git a/benchmark/crypto/get-ciphers.js b/benchmark/crypto/get-ciphers.js
@@ -9,7 +9,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, v }) {
 const method = require(v).getCiphers;
- var i = 0;
+ let i = 0;
 // First call to getCiphers will dominate the results
 if (n > 1) {
 for (; i < n; i++)
diff --git a/benchmark/crypto/hash-stream-creation.js b/benchmark/crypto/hash-stream-creation.js
@@ -20,8 +20,8 @@ function main({ api, type, len, out, writes, algo }) {
 api = 'legacy';
 }
 
- var message;
- var encoding;
+ let message;
+ let encoding;
 switch (type) {
 case 'asc':
 message = 'a'.repeat(len);
@@ -52,7 +52,7 @@ function legacyWrite(algo, message, encoding, writes, len, outEnc) {
 while (writes-- > 0) {
 const h = crypto.createHash(algo);
 h.update(message, encoding);
- var res = h.digest(outEnc);
+ let res = h.digest(outEnc);
 
 // Include buffer creation costs for older versions
 if (outEnc === 'buffer' && typeof res === 'string')
diff --git a/benchmark/crypto/hash-stream-throughput.js b/benchmark/crypto/hash-stream-throughput.js
@@ -19,8 +19,8 @@ function main({ api, type, len, algo, writes }) {
 api = 'legacy';
 }
 
- var message;
- var encoding;
+ let message;
+ let encoding;
 switch (type) {
 case 'asc':
 message = 'a'.repeat(len);
diff --git a/benchmark/crypto/rsa-encrypt-decrypt-throughput.js b/benchmark/crypto/rsa-encrypt-decrypt-throughput.js
@@ -35,7 +35,7 @@ function StreamWrite(algo, keylen, message, n, len) {
 
 const privateKey = RSA_PrivatePem[keylen];
 const publicKey = RSA_PublicPem[keylen];
- for (var i = 0; i < n; i++) {
+ for (let i = 0; i < n; i++) {
 const enc = crypto.privateEncrypt(privateKey, message);
 crypto.publicDecrypt(publicKey, enc);
 }

-Original file line number
+Diff line change
 constbits=written*8;
 constmbits=bits/(1024*1024);
 -for(vari=0;i<n;i++){
 +for(leti=0;i<n;i++){
 constalice=crypto.createCipheriv(cipher,key,iv);
 alice.setAAD(associate_data);
 constenc=alice.update(message);
-Original file line number
+Diff line change
 constalice_cipher=crypto.createCipher(cipher,alice_secret);
 constbob_cipher=crypto.createDecipher(cipher,bob_secret);
 -varmessage;
 -varencoding;
 +letmessage;
 +letencoding;
 switch(type){
 case'asc':
 message='a'.repeat(len);
+}
 functionstreamWrite(alice,bob,message,encoding,writes){
 -varwritten=0;
 +letwritten=0;
 bob.on('data',(c)=>{
 written+=c.length;
 });
+}
 functionlegacyWrite(alice,bob,message,encoding,writes){
 -varwritten=0;
 -varenc,dec;
 -for(vari=0;i<writes;i++){
 +letwritten=0;
 +letenc,dec;
 +for(leti=0;i<writes;i++){
 enc=alice.update(message,encoding);
 dec=bob.update(enc);
 written+=dec.length;
-Original file line number
+Diff line change
 functionmain({ n, v }){
 constmethod=require(v).getCiphers;
 -vari=0;
 +leti=0;
 // First call to getCiphers will dominate the results
 if(n>1){
 for(;i<n;i++)
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ function StreamWrite(algo, keylen, message, n, len) {`
`35`	`35`
`36`	`36`	`constprivateKey=RSA_PrivatePem[keylen];`
`37`	`37`	`constpublicKey=RSA_PublicPem[keylen];`
`38`		`-for(vari=0;i<n;i++){`
	`38`	`+for(leti=0;i<n;i++){`
`39`	`39`	`constenc=crypto.privateEncrypt(privateKey,message);`
`40`	`40`	`crypto.publicDecrypt(publicKey,enc);`
`41`	`41`	`}`