Skip to content

benchmark: use let instead of var in crypto - #31135

Closed
dnlup wants to merge 1 commit into
nodejs:masterfrom
dnlup:benchmark_crypto
Closed

benchmark: use let instead of var in crypto#31135
dnlup wants to merge 1 commit into
nodejs:masterfrom
dnlup:benchmark_crypto

Conversation

@dnlup

@dnlupdnlup commented Dec 30, 2019

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. crypto Issues and PRs related to the crypto subsystem. labels Dec 30, 2019
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 1, 2020
@Trott

Trott commented Jan 1, 2020

Copy link
Copy Markdown
Member

I ran test/benchmark/test-benchmark-crypto.js locally with this change to confirm it didn't break anything. (That test isn't run in our regular CI, only nightly.)

@Trott

Trott commented Jan 1, 2020

Copy link
Copy Markdown
Member

Landed in 7365000

@TrottTrott closed this Jan 1, 2020
Trott pushed a commit that referenced this pull request Jan 1, 2020
@dnlup@Trott
benchmark: use let instead of var in crypto
7365000
PR-URL: #31135
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
@dnlup@BridgeAR
benchmark: use let instead of var in crypto
b193142
PR-URL: #31135
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeARBridgeAR mentioned this pull request Jan 7, 2020
Merged
@dnlup
dnlup deleted the benchmark_crypto branch January 10, 2020 13:38
targos pushed a commit that referenced this pull request Jan 14, 2020
@dnlup@targos
benchmark: use let instead of var in crypto
d30911e
PR-URL: #31135
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targostargos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@dnlup@BethGriggs
benchmark: use let instead of var in crypto
1c97163
PR-URL: #31135
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.benchmarkIssues and PRs related to the benchmark subsystem.cryptoIssues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dnlup@Trott@BridgeAR@trivikr@nodejs-github-bot