test: use eslint to fix var->const/let

Manually fix issues that eslint --fix couldn't do automatically.
Backport-PR-URL: #11775
PR-URL: #10685
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

Author: gibfahn

test/addons/async-hello-world/test.js

@@ -1,6 +1,6 @@
 'use strict';
 constcommon=require('../../common');
-varassert=require('assert');
+constassert=require('assert');
 constbinding=require(`./build/${common.buildType}/binding`);
 
 binding(5,common.mustCall(function(err,val){

test/addons/buffer-free-callback/test.js

@@ -5,8 +5,8 @@ const common = require('../../common');
 constbinding=require(`./build/${common.buildType}/binding`);
 
 functioncheck(size,alignment,offset){
-varbuf=binding.alloc(size,alignment,offset);
-varslice=buf.slice(size>>>1);
+letbuf=binding.alloc(size,alignment,offset);
+letslice=buf.slice(size>>>1);
 
 buf=null;
 binding.check(slice);

test/addons/hello-world-function-export/test.js

@@ -1,6 +1,6 @@
 'use strict';
 constcommon=require('../../common');
-varassert=require('assert');
+constassert=require('assert');
 constbinding=require(`./build/${common.buildType}/binding`);
 assert.strictEqual(binding(),'world');
 console.log('binding.hello() =',binding());

test/addons/hello-world/test.js

@@ -1,6 +1,6 @@
 'use strict';
 constcommon=require('../../common');
-varassert=require('assert');
+constassert=require('assert');
 constbinding=require(`./build/${common.buildType}/binding`);
 assert.strictEqual(binding.hello(),'world');
 console.log('binding.hello() =',binding.hello());

test/addons/load-long-path/test.js

@@ -14,9 +14,9 @@ common.refreshTmpDir();
 // make a path that is more than 260 chars long.
 // Any given folder cannot have a name longer than 260 characters,
 // so create 10 nested folders each with 30 character long names.
-varaddonDestinationDir=path.resolve(common.tmpDir);
+letaddonDestinationDir=path.resolve(common.tmpDir);
 
-for(vari=0;i<10;i++){
+for(leti=0;i<10;i++){
 addonDestinationDir=path.join(addonDestinationDir,'x'.repeat(30));
 fs.mkdirSync(addonDestinationDir);
 }
@@ -28,10 +28,10 @@ const addonPath = path.join(__dirname,
 constaddonDestinationPath=path.join(addonDestinationDir,'binding.node');
 
 // Copy binary to long path destination
-varcontents=fs.readFileSync(addonPath);
+constcontents=fs.readFileSync(addonPath);
 fs.writeFileSync(addonDestinationPath,contents);
 
 // Attempt to load at long path destination
-varaddon=require(addonDestinationPath);
+constaddon=require(addonDestinationPath);
 assert.notEqual(addon,null);
 assert.strictEqual(addon.hello(),'world');

test/addons/make-callback-recurse/test.js

@@ -65,7 +65,7 @@ assert.throws(function() {
 results.push(2);
 
 setImmediate(common.mustCall(function(){
-for(vari=0;i<results.length;i++){
+for(leti=0;i<results.length;i++){
 assert.strictEqual(results[i],i,
 `verifyExecutionOrder(${arg}) results: ${results}`);
 }

test/addons/repl-domain-abort/test.js

@@ -1,30 +1,30 @@
 'use strict';
-varcommon=require('../../common');
-varassert=require('assert');
-varrepl=require('repl');
-varstream=require('stream');
-varpath=require('path');
-varbuildType=process.config.target_defaults.default_configuration;
-varbuildPath=path.join(__dirname,'build',buildType,'binding');
+constcommon=require('../../common');
+constassert=require('assert');
+constrepl=require('repl');
+conststream=require('stream');
+constpath=require('path');
+constbuildType=process.config.target_defaults.default_configuration;
+letbuildPath=path.join(__dirname,'build',buildType,'binding');
 // On Windows, escape backslashes in the path before passing it to REPL.
 if(common.isWindows)
 buildPath=buildPath.replace(/\\/g,'/');
-varcb_ran=false;
+letcb_ran=false;
 
 process.on('exit',function(){
 assert(cb_ran);
 console.log('ok');
 });
 
-varlines=[
+constlines=[
 // This line shouldn't cause an assertion error.
 'require(\''+buildPath+'\')'+
 // Log output to double check callback ran.
 '.method(function() { console.log(\'cb_ran\'); });',
 ];
 
-vardInput=newstream.Readable();
-vardOutput=newstream.Writable();
+constdInput=newstream.Readable();
+constdOutput=newstream.Writable();
 
 dInput._read=function_read(size){
 while(lines.length>0&&this.push(lines.shift()));
@@ -38,7 +38,7 @@ dOutput._write = function _write(chunk, encoding, cb) {
 cb();
 };
 
-varoptions={
+constoptions={
 input: dInput,
 output: dOutput,
 terminal: false,

test/addons/stringbytes-external-exceed-max/test-stringbytes-external-at-max.js

@@ -14,8 +14,9 @@ if (!common.enoughTestMem) {
 return;
 }
 
+letbuf;
 try{
-varbuf=Buffer.allocUnsafe(kStringMaxLength);
+buf=Buffer.allocUnsafe(kStringMaxLength);
 }catch(e){
 // If the exception is not due to memory confinement then rethrow it.
 if(e.message!=='Array buffer allocation failed')throw(e);

test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-ascii.js

@@ -14,8 +14,9 @@ if (!common.enoughTestMem) {
 // v8::String::kMaxLength defined in v8.h
 constkStringMaxLength=process.binding('buffer').kStringMaxLength;
 
+letbuf;
 try{
-varbuf=Buffer.allocUnsafe(kStringMaxLength+1);
+buf=Buffer.allocUnsafe(kStringMaxLength+1);
 }catch(e){
 // If the exception is not due to memory confinement then rethrow it.
 if(e.message!=='Array buffer allocation failed')throw(e);

test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-base64.js

@@ -14,8 +14,9 @@ if (!common.enoughTestMem) {
 // v8::String::kMaxLength defined in v8.h
 constkStringMaxLength=process.binding('buffer').kStringMaxLength;
 
+letbuf;
 try{
-varbuf=Buffer.allocUnsafe(kStringMaxLength+1);
+buf=Buffer.allocUnsafe(kStringMaxLength+1);
 }catch(e){
 // If the exception is not due to memory confinement then rethrow it.
 if(e.message!=='Array buffer allocation failed')throw(e);