Uh oh!
There was an error while loading. Please reload this page.
v6.x backport - test: convert var->const/let in tests - #11775
Closed
gibfahn wants to merge 5 commits into
Closed
Conversation
gibfahn
commented
Mar 9, 2017
MemberAuthor
CI: https://ci.nodejs.org/job/node-test-commit/8347/ Once CI is passing I'll squash and tidy up. @MylesBorins |
MemberAuthor
CI was green, squashing and rerunning. If anyone wants to review, var2const-v6.x-presquash has the pre-squash commits (the most recent 4 commits are the ones that were manual). CI 2: https://ci.nodejs.org/job/node-test-commit/8358/ Should be good to land if CI passes. |
gibfahn
commented
Mar 10, 2017
MemberAuthor
CI failure looks like an Jenkins/Git issue, rerunning to confirm: |
sam-github
approved these changes
Mar 10, 2017
4 tasks
2 tasks
TimothyGu
approved these changes
Mar 16, 2017
jasnell
commented
Mar 16, 2017
Member
largely rubber stamp LGTM assuming CI is all good |
2 tasks
PR-URL: nodejs#10980 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
Original Commit Message: PR-URL: nodejs#11872 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Backport-Of: nodejs#11872 PR-URL: nodejs#11943 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#11943 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
commented
Mar 22, 2017
Member
This needs a rebase on the current v6.x-staging |
Manually fix issues that eslint --fix couldn't do automatically.
gibfahn
commented
Mar 22, 2017
MemberAuthor
Done |
MylesBorins
commented
Apr 13, 2017
Contributor
landed in 078188d...b2fc0f0 |
andrew749 pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
Backport-PR-URL: nodejs/node#11775 PR-URL: nodejs/node#10685 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
andrew749 pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
Manually fix issues that eslint --fix couldn't do automatically. Backport-PR-URL: nodejs/node#11775 PR-URL: nodejs/node#10685 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll fix up the commit messages once the tests are passing.EDIT: They are.Backport of #10685, I couldn't cherry-pick as it brought in hundreds of unrelated changes, so I redid the eslint --fix and manual fixup for v6.x.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, tools