lib: remove unnecessary lazy loading in internal/encoding

aduh95 · targos · commit ed8ae88f307a · 2022-12-13T09:42:46.000Z
PR-URL: #45810 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
diff --git a/lib/internal/encoding.js b/lib/internal/encoding.js
@@ -56,12 +56,7 @@ const {
 decodeUTF8,
 } = internalBinding('buffer');
 
-let Buffer;
-function lazyBuffer() {
- if (Buffer === undefined)
- Buffer = require('buffer').Buffer;
- return Buffer;
-}
+const { Buffer } = require('buffer');
 
 function validateEncoder(obj) {
 if (obj == null || obj[kEncoder] !== true)
@@ -499,14 +494,14 @@ function makeTextDecoderJS() {
 validateDecoder(this);
 if (isAnyArrayBuffer(input)) {
 try {
- input = lazyBuffer().from(input);
+ input = Buffer.from(input);
 } catch {
 input = empty;
 }
 } else if (isArrayBufferView(input)) {
 try {
- input = lazyBuffer().from(input.buffer, input.byteOffset,
- input.byteLength);
+ input = Buffer.from(input.buffer, input.byteOffset,
+ input.byteLength);
 } catch {
 input = empty;
 }

-Original file line number
+Diff line change
  decodeUTF8,
 }=internalBinding('buffer');
 -letBuffer;
 -functionlazyBuffer(){
 -if(Buffer===undefined)
 -Buffer=require('buffer').Buffer;
 -returnBuffer;
 -}
 +const{ Buffer }=require('buffer');
 functionvalidateEncoder(obj){
 if(obj==null||obj[kEncoder]!==true)
 validateDecoder(this);
 if(isAnyArrayBuffer(input)){
 try{
 -input=lazyBuffer().from(input);
 +input=Buffer.from(input);
 }catch{
 input=empty;
+}
 }elseif(isArrayBufferView(input)){
 try{
 -input=lazyBuffer().from(input.buffer,input.byteOffset,
 -input.byteLength);
 +input=Buffer.from(input.buffer,input.byteOffset,
 +input.byteLength);
 }catch{
 input=empty;
+}