Uh oh!
There was an error while loading. Please reload this page.
lib: remove unnecessary lazy loading in internal/encoding - #45810
Merged
Conversation
daeyeon
commented
Dec 10, 2022
Member
Is the lazy loading valid in |
ContributorAuthor
Folks using a build of Node.js without the snapshot are choosing a slower bootstrap to get a better smaller binary, and since this change doesn't impact the binary size, I expect they don't really care about it. |
daeyeon
approved these changes
Dec 10, 2022
daeyeon
left a comment
Member
There was a problem hiding this comment.
Without such a function, I guess that a module now snapshotted would be hard to detect when it won't need to be snapshotted in the future. However, I agree with this change since it seems hard to make buffer not snapshotted even in the future.
nodejs-github-bot
commented
Dec 10, 2022
Collaborator
anonrig
approved these changes
Dec 11, 2022
nodejs-github-bot
commented
Dec 12, 2022
Collaborator
Landed in aa2ca81 |
targos pushed a commit
that referenced
this pull request
Dec 12, 2022
PR-URL: #45810 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos pushed a commit
that referenced
this pull request
Dec 13, 2022
PR-URL: #45810 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45810 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45810 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams
commented
Jan 4, 2023
Contributor
Requesting a backport to v18.x since it broke some tests in v18.x-staging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node:bufferis snapshotted, so there's no benefit in lazy loading it.