Skip to content

Commit f067876

Browse files
kuriyoshtargos
authored andcommitted
test: improve test coverage of dns/promises
PR-URL: #41133 Refs: https://coverage.nodejs.org/coverage-18ff5832501b66b4/lib/internal/dns/promises.js.html#L116 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
1 parent ef6f98c commit f067876

1 file changed

Lines changed: 32 additions & 0 deletions

File tree

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
// Flags: --expose-internals
2+
'use strict';
3+
constcommon=require('../common');
4+
constassert=require('assert');
5+
const{ internalBinding }=require('internal/test/binding');
6+
constcares=internalBinding('cares_wrap');
7+
cares.getaddrinfo=()=>internalBinding('uv').UV_ENOMEM;
8+
9+
// This test ensures that dns.lookup issue a DeprecationWarning
10+
// when invalid options type is given
11+
12+
constdnsPromises=require('dns/promises');
13+
14+
common.expectWarning({
15+
'internal/test/binding': [
16+
'These APIs are for internal testing only. Do not use them.',
17+
],
18+
'DeprecationWarning': {
19+
DEP0153: 'Type coercion of dns.lookup options is deprecated'
20+
}
21+
});
22+
23+
assert.throws(()=>{
24+
dnsPromises.lookup('127.0.0.1',{hints: '-1'});
25+
},{
26+
code: 'ERR_INVALID_ARG_VALUE',
27+
name: 'TypeError'
28+
});
29+
dnsPromises.lookup('127.0.0.1',{family: '6'});
30+
dnsPromises.lookup('127.0.0.1',{all: 'true'});
31+
dnsPromises.lookup('127.0.0.1',{verbatim: 'true'});
32+
dnsPromises.lookup('127.0.0.1','6');

0 commit comments

Comments
 (0)