Uh oh!
There was an error while loading. Please reload this page.
test: improve test coverage of dns/promises - #41133
Merged
Merged
Conversation
kuriyoshforce-pushed
the
dns-options-test
branch
from
December 10, 2021 13:35
7aa8603 to
53ad06eCompareaduh95
reviewed
Dec 10, 2021
Uh oh!
There was an error while loading. Please reload this page.
jasnell
commented
Dec 10, 2021
Member
Looks like there are some relevant test failures that need to be looked at! :-) |
kuriyoshforce-pushed
the
dns-options-test
branch
2 times, most recently
from
December 11, 2021 01:59
0c67e16 to
a197004Comparekuriyosh
commented
Dec 11, 2021
ContributorAuthor
There was a problem hiding this comment.
This test only check whether DeprecationWarning is emitted when hints is not a number.
Since the valid string value of hints depends on the OS environment, give an invalid string value here and assert the error.
kuriyoshforce-pushed
the
dns-options-test
branch
from
December 11, 2021 02:06
a197004 to
53771fbComparelpinca
approved these changes
Dec 11, 2021
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
commented
Dec 12, 2021
Collaborator
Ayase-252
approved these changes
Dec 13, 2021
This was referenced Dec 15, 2021
nodejs-github-bot
commented
Dec 19, 2021
Collaborator
Landed in 9b903d1 |
20 tasks
targos pushed a commit
that referenced
this pull request
Jan 14, 2022
PR-URL: #41133 Refs: https://coverage.nodejs.org/coverage-18ff5832501b66b4/lib/internal/dns/promises.js.html#L116 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
danielleadams
commented
Jan 31, 2022
Contributor
@kuriyosh This caused a failed test when pulling into the v16.x release. Do you mind creating a backport PR? |
kuriyosh
commented
Feb 4, 2022
ContributorAuthor
@danielleadams |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves a test coverage in lib/internal/dns/promises.
It tests emitting warning when the options types of lookup method are invalid.
ref: https://coverage.nodejs.org/coverage-18ff5832501b66b4/lib/internal/dns/promises.js.html#L116