repl: fix eval errors thrown after close throwing ERR_USE_AFTER_CLOSE

prevent incorrect throws of `ERR_USE_AFTER_CLOSE` errors when the eval
function of a repl server returns an error after the repl server
has been closed
PR-URL: #58791
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Author: dario-piotrowicz

lib/repl.js

@@ -741,7 +741,9 @@ function REPLServer(prompt,
 process.emit('uncaughtException',e);
 self.clearBufferedCommand();
 self.lines.level=[];
-self.displayPrompt();
+if(!self.closed){
+self.displayPrompt();
+}
 });
 }else{
 if(errStack===''){
@@ -771,7 +773,9 @@ function REPLServer(prompt,
 self.output.write(errStack);
 self.clearBufferedCommand();
 self.lines.level=[];
-self.displayPrompt();
+if(!self.closed){
+self.displayPrompt();
+}
 }
 });
 

test/parallel/test-repl-eval-error-after-close.js

@@ -0,0 +1,45 @@
+'use strict';
+
+constcommon=require('../common');
+constrepl=require('node:repl');
+conststream=require('node:stream');
+constassert=require('node:assert');
+
+// This test checks that an eval function returning an error in its callback
+// after the repl server has been closed doesn't cause an ERR_USE_AFTER_CLOSE
+// error to be thrown (reference: https://github.com/nodejs/node/issues/58784)
+
+(async()=>{
+constclose$=Promise.withResolvers();
+consteval$=Promise.withResolvers();
+
+constinput=newstream.PassThrough();
+constoutput=newstream.PassThrough();
+
+constreplServer=repl.start({
+ input,
+ output,
+eval(_cmd,_context,_file,cb){
+close$.promise.then(()=>{
+cb(newError('Error returned from the eval callback'));
+eval$.resolve();
+});
+},
+});
+
+letoutputStr='';
+output.on('data',(data)=>{
+outputStr+=data;
+});
+
+input.write('\n');
+
+replServer.close();
+close$.resolve();
+
+process.on('uncaughtException',common.mustNotCall());
+
+awaiteval$.promise;
+
+assert.match(outputStr,/UncaughtError:Errorreturnedfromtheevalcallback/);
+})().then(common.mustCall());