Uh oh!
There was an error while loading. Please reload this page.
repl: fix eval errors thrown after close throwing ERR_USE_AFTER_CLOSE - #58791
Conversation
prevent incorrect throws of `ERR_USE_AFTER_CLOSE` errors when the eval function of a repl server returns an error after the repl server has been closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #58791 +/- ##
==========================================
- Coverage 90.10% 90.09% -0.01%
==========================================
Files 640 640 Lines 188287 188291 +4 Branches 36916 36926 +10 ==========================================
- Hits 169651 169636 -15 - Misses 11355 11385 +30 + Partials 7281 7270 -11
🚀 New features to boost your workflow:
|
nodejs-github-bot
commented
Jun 22, 2025
hildjj
commented
Jun 22, 2025
I have confirmed that this patch fixes my issue. |
nodejs-github-bot
commented
Jun 22, 2025
nodejs-github-bot
commented
Jun 26, 2025
nodejs-github-bot
commented
Jun 28, 2025
Commit Queue failednode:internal/modules/esm/resolve:275 throw new ERR_MODULE_NOT_FOUND( ^https://github.com/nodejs/node/actions/runs/15943283499 |
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Jun 28, 2025
Landed in 9fe3316 |
prevent incorrect throws of `ERR_USE_AFTER_CLOSE` errors when the eval function of a repl server returns an error after the repl server has been closed PR-URL: #58791 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
prevent incorrect throws of `ERR_USE_AFTER_CLOSE` errors when the eval function of a repl server returns an error after the repl server has been closed PR-URL: #58791 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
prevent incorrect throws of `ERR_USE_AFTER_CLOSE` errors when the eval function of a repl server returns an error after the repl server has been closed PR-URL: #58791 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Fixes#58784
prevent incorrect throws of
ERR_USE_AFTER_CLOSEerrors when the eval function of a repl server returns an error after the repl server has been closed