test: get rid of unnecessary AbortController instanciations

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #63489
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: aduh95

test/parallel/test-fs-promises-file-handle-writer.js

@@ -458,11 +458,8 @@ async function testWriteWithAbortedSignalRejects() {
 constfh=awaitopen(filePath,'w');
 constw=fh.writer();
 
-constac=newAbortController();
-ac.abort();
-
 awaitassert.rejects(
-w.write(Buffer.from('data'),{signal: ac.signal}),
+w.write(Buffer.from('data'),{signal: AbortSignal.abort()}),
 {name: 'AbortError'},
 );
 
@@ -479,11 +476,8 @@ async function testWritevWithAbortedSignalRejects() {
 constfh=awaitopen(filePath,'w');
 constw=fh.writer();
 
-constac=newAbortController();
-ac.abort();
-
 awaitassert.rejects(
-w.writev([Buffer.from('a'),Buffer.from('b')],{signal: ac.signal}),
+w.writev([Buffer.from('a'),Buffer.from('b')],{signal: AbortSignal.abort()}),
 {name: 'AbortError'},
 );
 
@@ -501,11 +495,8 @@ async function testEndWithAbortedSignalRejects() {
 
 awaitw.write(Buffer.from('data'));
 
-constac=newAbortController();
-ac.abort();
-
 awaitassert.rejects(
-w.end({signal: ac.signal}),
+w.end({signal: AbortSignal.abort()}),
 {name: 'AbortError'},
 );
 

test/parallel/test-runner-mock-timers-scheduler.js

@@ -97,11 +97,9 @@ describe('Mock Timers Scheduler Test Suite', () => {
 
 it('should abort operation when .abort is called before calling setInterval',async(t)=>{
 t.mock.timers.enable({apis: ['scheduler.wait']});
-constcontroller=newAbortController();
-controller.abort();
 constp=nodeTimersPromises.scheduler.wait(2000,{
 ref: true,
-signal: controller.signal,
+signal: AbortSignal.abort(),
 });
 
 awaitassert.rejects(()=>p,{

test/parallel/test-runner-mock-timers.js

@@ -551,11 +551,9 @@ describe('Mock Timers Test Suite', () => {
 it('should abort operation when .abort is called before calling setInterval',async(t)=>{
 t.mock.timers.enable({apis: ['setTimeout']});
 constexpectedResult='result';
-constcontroller=newAbortController();
-controller.abort();
 constp=nodeTimersPromises.setTimeout(2000,expectedResult,{
 ref: true,
-signal: controller.signal,
+signal: AbortSignal.abort(),
 });
 
 awaitassert.rejects(()=>p,{
@@ -778,10 +776,8 @@ describe('Mock Timers Test Suite', () => {
 t.mock.timers.enable({apis: ['setInterval']});
 
 constinterval=100;
-constabortController=newAbortController();
-abortController.abort();
 constintervalIterator=nodeTimersPromises.setInterval(interval,Date.now(),{
-signal: abortController.signal,
+signal: AbortSignal.abort(),
 });
 
 constfirst=intervalIterator.next();

test/parallel/test-stream-iter-broadcast-from.js

@@ -79,10 +79,7 @@ async function testAbortSignal() {
 }
 
 asyncfunctiontestAlreadyAbortedSignal(){
-constac=newAbortController();
-ac.abort();
-
-const{broadcast: bc}=broadcast({signal: ac.signal});
+const{broadcast: bc}=broadcast({signal: AbortSignal.abort()});
 constconsumer=bc.push();
 
 awaitassert.rejects(async()=>{

test/parallel/test-stream-iter-consumers-bytes.js

@@ -45,10 +45,8 @@ async function testBytesAsyncLimit() {
 }
 
 asyncfunctiontestBytesAsyncAbort(){
-constac=newAbortController();
-ac.abort();
 awaitassert.rejects(
-()=>bytes(from('data'),{signal: ac.signal}),
+()=>bytes(from('data'),{signal: AbortSignal.abort()}),
 {name: 'AbortError'},
 );
 }

test/parallel/test-stream-iter-consumers-merge.js

@@ -55,10 +55,7 @@ async function testMergeEmpty() {
 }
 
 asyncfunctiontestMergeWithAbortSignal(){
-constac=newAbortController();
-ac.abort();
-
-constmerged=merge(from('data'),{signal: ac.signal});
+constmerged=merge(from('data'),{signal: AbortSignal.abort()});
 
 awaitassert.rejects(
 async()=>{

test/parallel/test-stream-iter-consumers-text.js

@@ -96,10 +96,8 @@ async function testTextEmpty() {
 
 // text() with abort signal
 asyncfunctiontestTextWithSignal(){
-constac=newAbortController();
-ac.abort();
 awaitassert.rejects(
-()=>text(from('data'),{signal: ac.signal}),
+()=>text(from('data'),{signal: AbortSignal.abort()}),
 {name: 'AbortError'},
 );
 }

test/parallel/test-stream-iter-pull-async.js

@@ -41,14 +41,11 @@ async function testPullStatefulTransform() {
 }
 
 asyncfunctiontestPullWithAbortSignal(){
-constac=newAbortController();
-ac.abort();
-
 asyncfunction*gen(){
 yield[newUint8Array([1])];
 }
 
-constresult=pull(gen(),{signal: ac.signal});
+constresult=pull(gen(),{signal: AbortSignal.abort()});
 awaitassert.rejects(
 async()=>{
 // eslint-disable-next-line no-unused-vars

test/parallel/test-stream-iter-push-basic.js

@@ -109,9 +109,7 @@ async function testAbortSignal() {
 }
 
 asyncfunctiontestPreAbortedSignal(){
-constac=newAbortController();
-ac.abort();
-const{ readable }=push({signal: ac.signal});
+const{ readable }=push({signal: AbortSignal.abort()});
 awaitassert.rejects(async()=>{
 // eslint-disable-next-line no-unused-vars
 forawait(const_ofreadable){

test/parallel/test-stream-iter-push-writer.js

@@ -61,12 +61,9 @@ async function testWriteWithSignalRejects() {
 asyncfunctiontestWriteWithPreAbortedSignal(){
 const{ writer, readable }=push({highWaterMark: 1});
 
-constac=newAbortController();
-ac.abort();
-
 // Pre-aborted signal should reject immediately
 awaitassert.rejects(
-writer.write('data',{signal: ac.signal}),
+writer.write('data',{signal: AbortSignal.abort()}),
 {name: 'AbortError'},
 );