test: get rid of unnecessary `AbortController` instanciations by aduh95 · Pull Request #63489 · nodejs/node

aduh95 · 2026-05-22T15:13:11Z

I've considered doing a lint rule, but the effort to verify if the controller is used elsewhere makes it probably not worth it.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

nodejs-github-bot · 2026-05-22T15:13:20Z

Review requested:

@nodejs/test_runner

codecov · 2026-05-22T16:42:54Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.13%. Comparing base (3553a34) to head (ce5e1c9).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #63489 +/- ##
=======================================
Coverage 90.13% 90.13% =======================================
Files 718 718 Lines 227914 227914 Branches 42811 42812 +1 =======================================
+ Hits 205435 205437 +2 + Misses 14248 14244 -4 - Partials 8231 8233 +2

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2026-05-22T18:18:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/73620/

nodejs-github-bot · 2026-05-22T21:11:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/73624/

mcollina

lgtm

atlowChemi · 2026-05-23T20:39:24Z

@@ -97,11 +97,9 @@ describe('Mock Timers Scheduler Test Suite', () => {

 it('should abort operation when .abort is called before calling setInterval', async (t) => {


Should this be renames to something like
Suggested change
it('should abort operation when .abort is called before calling setInterval',async(t)=>{
it('should abort operation when signal is aborted before calling wait',async(t)=>{
The name is already incorrect as it says setInterval, though

atlowChemi · 2026-05-23T20:40:47Z

@@ -551,11 +551,9 @@ describe('Mock Timers Test Suite', () => {
 it('should abort operation when .abort is called before calling setInterval', async (t) => {


This one too is setInterval instead of setTimeout, I see this is not just one test, and not really related to your change.
Probably worth a separate PR

nodejs-github-bot · 2026-05-24T15:21:00Z

Landed in 8c3e9bd

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #63489 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: nodejs#63489 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Assisted-by: openai:gpt-5.5

Refs: #63489 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Assisted-by: openai:gpt-5.5 PR-URL: #63541 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #63489 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: #63489 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Assisted-by: openai:gpt-5.5 PR-URL: #63541 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

test: get rid of unnecessary AbortController instanciations
ce5e1c9
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 22, 2026

avivkeller approved these changes May 22, 2026
View reviewed changes

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 22, 2026

legendecas approved these changes May 22, 2026
View reviewed changes

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 22, 2026

Renegade334 approved these changes May 22, 2026
View reviewed changes

trivikr approved these changes May 22, 2026
View reviewed changes

This comment was marked as outdated.
Sign in to view

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 22, 2026

mcollina approved these changes May 23, 2026
View reviewed changes

gurgunday approved these changes May 23, 2026
View reviewed changes

lpinca approved these changes May 23, 2026
View reviewed changes

atlowChemi reviewed May 23, 2026
View reviewed changes

atlowChemi approved these changes May 23, 2026
View reviewed changes

jasnell approved these changes May 23, 2026
View reviewed changes

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 24, 2026

nodejs-github-bot merged commit 8c3e9bd into nodejs:mainMay 24, 2026
96 of 97 checks passed

trivikr mentioned this pull request May 24, 2026
tools: add lint rule for aborted AbortController #63541
Merged

github-actionsBot mentioned this pull request May 30, 2026
2026-06-01, Version 26.3.0 (Current) #63664
Merged

Navigation Menu

Uh oh!

Uh oh!

test: get rid of unnecessary `AbortController` instanciations - #63489

test: get rid of unnecessary `AbortController` instanciations#63489
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:AbortSignal.abort

aduh95 commented May 22, 2026

Uh oh!

nodejs-github-bot commented May 22, 2026

Uh oh!

codecovBot commented May 22, 2026•
edited
Loading

Uh oh!

nodejs-github-bot commented May 22, 2026

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented May 22, 2026

Uh oh!

mcollina left a comment

Uh oh!

atlowChemiMay 23, 2026

Uh oh!

atlowChemiMay 23, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented May 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

		@@ -97,11 +97,9 @@ describe('Mock Timers Scheduler Test Suite', () => {

		it('should abort operation when .abort is called before calling setInterval', async (t) => {

	it('should abort operation when .abort is called before calling setInterval',async(t)=>{
	it('should abort operation when signal is aborted before calling wait',async(t)=>{

		@@ -551,11 +551,9 @@ describe('Mock Timers Test Suite', () => {
		it('should abort operation when .abort is called before calling setInterval', async (t) => {

Uh oh!

Uh oh!

Conversation

aduh95 commented May 22, 2026

Uh oh!

nodejs-github-bot commented May 22, 2026

Uh oh!

codecovBot commented May 22, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented May 22, 2026

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented May 22, 2026

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

atlowChemiMay 23, 2026

Choose a reason for hiding this comment

Uh oh!

atlowChemiMay 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nodejs-github-bot commented May 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

codecovBot commented May 22, 2026•
edited
Loading