util: text decoding allows SharedArrayBuffer

bfarias-godaddy · MylesBorins · commit fa1fa3111acb · 2020-03-24T02:55:05.000-04:00
PR-URL: #32203 Fixes: #32199 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/internal/encoding.js b/lib/internal/encoding.js
@@ -31,7 +31,7 @@ const {
 } = require('internal/util');
 
 const {
- isArrayBuffer,
+ isAnyArrayBuffer,
 isArrayBufferView,
 isUint8Array
 } = require('internal/util/types');
@@ -404,7 +404,7 @@ function makeTextDecoderICU() {
 
 decode(input = empty, options = {}) {
 validateDecoder(this);
- if (isArrayBuffer(input)) {
+ if (isAnyArrayBuffer(input)) {
 input = lazyBuffer().from(input);
 } else if (!isArrayBufferView(input)) {
 throw new ERR_INVALID_ARG_TYPE('input',
@@ -469,7 +469,7 @@ function makeTextDecoderJS() {
 
 decode(input = empty, options = {}) {
 validateDecoder(this);
- if (isArrayBuffer(input)) {
+ if (isAnyArrayBuffer(input)) {
 input = lazyBuffer().from(input);
 } else if (isArrayBufferView(input)) {
 input = lazyBuffer().from(input.buffer, input.byteOffset,

-Original file line number
+Diff line change
 }=require('internal/util');
 const{
 -isArrayBuffer,
 +isAnyArrayBuffer,
  isArrayBufferView,
  isUint8Array
 }=require('internal/util/types');
 decode(input=empty,options={}){
 validateDecoder(this);
 -if(isArrayBuffer(input)){
 +if(isAnyArrayBuffer(input)){
 input=lazyBuffer().from(input);
 }elseif(!isArrayBufferView(input)){
 thrownewERR_INVALID_ARG_TYPE('input',
 decode(input=empty,options={}){
 validateDecoder(this);
 -if(isArrayBuffer(input)){
 +if(isAnyArrayBuffer(input)){
 input=lazyBuffer().from(input);
 }elseif(isArrayBufferView(input)){
 input=lazyBuffer().from(input.buffer,input.byteOffset,