Uh oh!
There was an error while loading. Please reload this page.
util: text decoding allows SharedArrayBuffer - #32203
Closed
bmeck wants to merge 1 commit into
Closed
Conversation
addaleax
approved these changes
Mar 11, 2020
cjihrig
approved these changes
Mar 11, 2020
BridgeAR
approved these changes
Mar 11, 2020
nodejs-github-bot
commented
Mar 11, 2020
Collaborator
devsnek
approved these changes
Mar 11, 2020
bmeck
commented
Mar 11, 2020
MemberAuthor
upstream has the tests already, but updating our fixtures is apparently not clean: #32208 |
jasnell
approved these changes
Mar 11, 2020
lpinca
approved these changes
Mar 12, 2020
Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/29782/ (:white_check_mark:) |
addaleax
commented
Mar 13, 2020
Member
Landed in 417d847 |
addaleax pushed a commit
that referenced
this pull request
Mar 13, 2020
PR-URL: #32203Fixes: #32199 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR pushed a commit
that referenced
this pull request
Mar 17, 2020
PR-URL: #32203Fixes: #32199 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Mar 24, 2020
PR-URL: #32203Fixes: #32199 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit
that referenced
this pull request
Apr 22, 2020
PR-URL: #32203Fixes: #32199 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesFixes: #32199
Tests are needed to be placed in upstream at https://github.com/web-platform-tests/wpt which is where all our
TextDecodertests come from.