Reuse TLS sessions in HTTPS client

[bajtos]

The HTTPS client created via require('https').request() should reuse TLS sessions by default.

Sample code:

var sessions = [];

get(function() {
 get(function() {
 require('assert').equal(sessions[0].toString('hex'), sessions[1].toString('hex'));
 console.log('PASS');
 });
});

function get(cb) {
 return new Promise(function(resolve, reject) {
 require('https').request(
 { host: 'github.com', headers: { connection: 'close' } },
 function(res) {
 sessions.push(res.connection.getSession());
 res.resume();
 res.on('end', cb);
 })
 .end();
 })
}

/cc @indutny

[bajtos]

Strangely enough, passing the result of getSession to the second request does not work as expected.

var sessions = [];

get(function() {
 get(function() {
 require('assert').equal(sessions[0].toString('hex'), sessions[1].toString('hex'));
 console.log('PASS');
 });
});

function get(cb) {
 return new Promise(function(resolve, reject) {
 require('https').request(
 { host: 'github.com', headers: { connection: 'close' }, session: sessions[0] },
 function(res) {
 sessions.push(res.connection.getSession());
 res.resume();
 res.on('end', function() { cb(); });
 })
 .end();
 })
}

The first request passes, the second request fails with the following error:

tls.js:176
 var commonNames = cert.subject.CN;
 ^
TypeError: Cannot read property 'CN' of undefined
 at Object.checkServerIdentity (tls.js:176:37)
 at TLSSocket.<anonymous> (_tls_wrap.js:913:29)
 at emitNone (events.js:67:13)
 at TLSSocket.emit (events.js:163:7)
 at TLSSocket._finishInit (_tls_wrap.js:496:8)

io.js version 1.8.1.

[ChALkeR]

The first request passes, the second request fails

Add checkServerIdentity: function(){} to the options of the second request.

[indutny]

Fix is here: #2228

[brendanashworth]

This was fixed in 2ca5a3d.