streamError never emitted

[ronag]

Reading the http/2 compat code it mentions a streamError on the server object.

function onStreamError(error) {
 // this is purposefully left blank
 //
 // errors in compatibility mode are
 // not forwarded to the request
 // and response objects. However,
 // they are forwarded to 'streamError'
 // on the server by Http2Stream
}

However, this doesn't seem to be emitted anywhere in the code? Is this something that has been removed from core http/2 and has a leftovers in compat and docs?

[Trott]

@nodejs/http2

[ryzokuken]

You're right, streamError isn't emitted anywhere in the source code. Adding the "confirmed" label.

[ryzokuken]

The docs say:

#### Event: 'streamError'
<!-- YAML
added: v8.5.0
-->

If a `ServerHttp2Stream` emits an `'error'` event, it will be forwarded here.
The stream will already be destroyed when this event is triggered.

[ryzokuken]

@mcollina @mafintosh this could be resolved by attatching a listener onto the corresponding ServerHttp2Stream that'd emit streamError on the current instance, right?

[apapirovski]

streamError was removed at some point and the documentation + the code comments are just lagging behind.

[mcollina]

All of this is buggy and needs to be refactored. However, there are multiple intiative/prs going in parallel. There is also an old PR from myself that was reverted that fixed some of this, and I forgot to resubmit.

Can you please leave it alone for some weeks? I’m currently on vacation and with all the rush of Node 10 I had no time to write all of this down.

streamError is part of the HTTP1 compatibility mode, and it’s a good destination. It should not be removed.

[apapirovski]

@mcollina I don't think streamError exists in the current codebase and I've gone through it several times. I believe it was removed in 0babd18

ping @jasnell to ascertain whether that was intentional or not

[mcollina]

This should be fixed first: #19852. It fixes the problems introduced by that PR. It’s not done yet and it can use some help.

I am on vacation for next week or so with limited connectivity.