Node 10.0.0 Object.values() returns incorrect array

[raymondfeng]

• Version: v10.0.0
• Platform: Darwin Kernel Version 17.5.0: Mon Mar 5 22:24:32 PST 2018; root:xnu-4570.51.1~1/RELEASE_X86_64 x86_64

To reproduce the problem, create the following js files:

1. values.js

"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
class X {
}
exports.X = X;

2. test.js

const x = require('./values.js');
console.log(x);
console.log(Object.values(x));

3. test1.js

const x = require('./values.js');
console.log(Object.values(x));

Now node test prints:

{ X: [Function: X] }
[]

Interestingly, node test1 prints:

[ [Function: X] ]

Please note Object.values(x) in test.js returns []. I expect it to print:

{ X: [Function: X] }
[ [Function: X] ]

I tried Node 8.x, both test and test1 work as expected.

[apapirovski]

@AyushG3112 Are you sure? I can definitely reproduce, on multiple platforms.

[AyushG3112]

@apapirovski nevermind, looks like my PC had some version conflicts while installing v10.0.0 from nvm. Will try fixing those and will try again. (deleting previous comment till then)

[apapirovski]

Ouch...

'use strict';
const obj = {};
Object.defineProperty(obj, 'ibreakyourobjects', { value: true });
obj.X = true;
console.log(Object.values(obj));
// [ true ]
Object.keys(obj);
console.log(Object.values(obj));
// []

ping @nodejs/v8 this looks bad to me...

[apapirovski]

Also, adding enumerable: true on ibreakyourobjects fixes the bug... (setting it to false breaks it again)

[ChALkeR]

I can definitely reproduce this in Chromium 66.0.3359.117.

[apapirovski]

Also, swapping order of declarations like so:

'use strict';
const obj = {};
obj.X = true;
Object.defineProperty(obj, 'ibreakyourobjects', { value: true });
obj.Y = true;
console.log(Object.values(obj));
// [ true, true ]
Object.keys(obj);
console.log(Object.values(obj));
// [ true ]

Note how the one before the defineProperty is still there but the one after isn't.

Edit: I can reproduce on 67.0.3396.10

[hashseed]

I can reproduce in V8, and will bisect.

[targos]

I can reproduce with V8 canary.

Opened https://bugs.chromium.org/p/v8/issues/detail?id=7687 upstream.

[xaviergonz]

V8 issue with the recent optimizations for speed of Object.values and Object.entries: https://bugs.chromium.org/p/chromium/issues/detail?id=836145&can=2&start=0&num=100&q=&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified&groupby=&sort=