Investigate flaky test/parallel/test-worker-message-port-transfer-closed.js

[Trott]

• Version: 11.0.0-pre
• Platform: freebsd10-64
• Subsystem: test

https://ci.nodejs.org/job/node-test-commit-freebsd/19100/nodes=freebsd10-64/console

03:24:55 not ok 1993 parallel/test-worker-message-port-transfer-closed
03:24:55 ---
03:24:55 duration_ms: 4.999
03:24:55 severity: fail
03:24:55 exitcode: 1
03:24:55 stack: |-
03:24:55 assert.js:84
03:24:55 throw new AssertionError(obj);
03:24:55 ^
03:24:55 
03:24:55 AssertionError [ERR_ASSERTION]: The communication channel is still open at /usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-worker-message-port-transfer-closed.js:53
03:24:55 at Timeout.mustNotCall [as _onTimeout] (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/common/index.js:533:12)
03:24:55 at ontimeout (timers.js:454:11)
03:24:55 at tryOnTimeout (timers.js:326:5)
03:24:55 at listOnTimeout (timers.js:300:5)
03:24:55 at processTimers (timers.js:257:5)
03:24:55 ...

[Trott]

The problem here is all but certainly the arbitrary-ish 1 second setTimeout() at the end of the test. FreeBSD is probably our CI platform most sensitive to race conditions in parallel. Moving this to sequential is the thing to do if the setTimeout() can't be removed or replaced with an event-based callback or something like that.

[Trott]

Stress test to hopefully confirm flakiness on master: https://ci.nodejs.org/job/node-stress-single-test/1967/nodes=freebsd10-64/console