Investigate flaky parallel/test-gc-http-client

[Trott]

• Version: 11.0.0-pre (master)
• Platform: freebsd11-x64
• Subsystem: test

https://ci.nodejs.org/job/node-test-commit-freebsd/19681/nodes=freebsd11-x64/console

00:08:04 not ok 694 parallel/test-gc-http-client
00:08:04 ---
00:08:04 duration_ms: 0.545
00:08:04 severity: fail
00:08:04 exitcode: 1
00:08:04 stack: |-
00:08:04 We should do 500 requests
00:08:04 Done: 0/500
00:08:04 Collected: 0/154
00:08:04 events.js:167
00:08:04 throw er; // Unhandled 'error' event
00:08:04 ^
00:08:04 
00:08:04 Error: connect ECONNRESET 127.0.0.1:15615 - Local (127.0.0.1:27660)
00:08:04 at internalConnect (net.js:933:16)
00:08:04 at defaultTriggerAsyncIdScope (internal/async_hooks.js:294:19)
00:08:04 at GetAddrInfoReqWrap.emitLookup [as callback] (net.js:1080:9)
00:08:04 at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:62:10)
00:08:04 Emitted 'error' event at:
00:08:04 at Socket.socketErrorListener (_http_client.js:399:9)
00:08:04 at Socket.emit (events.js:182:13)
00:08:04 at emitErrorNT (internal/streams/destroy.js:82:8)
00:08:04 at emitErrorAndCloseNT (internal/streams/destroy.js:50:3)
00:08:04 at process._tickCallback (internal/process/next_tick.js:63:19)
00:08:04 ...

[joyeecheung]

This also timeouts from time to time. In the last 100 runs:

Reason parallel/test-gc-http-client
Type JS_TEST_FAILURE
Failed PR 5 (#22291, #22289, #22286, #22074, #22152)
Appeared test-digitalocean-ubuntu1604_sharedlibs_container-x64-10, test-digitalocean-freebsd11-x64-1, test-digitalocean-ubuntu1604_sharedlibs_container-x64-9, test-digitalocean-ubuntu1604_sharedlibs_container-x64-8, test-digitalocean-ubuntu1604_sharedlibs_container-x64-7
First CI https://ci.nodejs.org/job/node-test-pull-request/16401/
Last CI https://ci.nodejs.org/job/node-test-pull-request/16420/

Example:

not ok 759 parallel/test-gc-http-client
 ---
 duration_ms: 480.47
 severity: fail
 exitcode: -15
 stack: |-
 timeout
 We should do 500 requests
 Done: 0/500
 Collected: 0/11
 Done: 0/500
 Collected: 0/22
 Done: 0/500
 Collected: 0/33
 Done: 0/500
 Collected: 0/44
 Done: 11/500
 Collected: 0/55
 Done: 22/500
 Collected: 0/66
 Done: 33/500
 Collected: 11/77
 Done: 44/500
 Collected: 22/88
 Done: 55/500
 Collected: 33/99
 Done: 66/500
 Coll...

[Trott]

Again today: https://ci.nodejs.org/job/node-test-commit-freebsd/19713/nodes=freebsd11-x64/console

03:34:55 not ok 728 parallel/test-gc-http-client
03:34:55 ---
03:34:55 duration_ms: 0.398
03:34:55 severity: fail
03:34:55 exitcode: 1
03:34:55 stack: |-
03:34:55 We should do 500 requests
03:34:55 Done: 0/500
03:34:55 Collected: 0/198
03:34:55 events.js:167
03:34:55 throw er; // Unhandled 'error' event
03:34:55 ^
03:34:55 
03:34:55 Error: connect ECONNRESET 127.0.0.1:65483 - Local (127.0.0.1:10142)
03:34:55 at internalConnect (net.js:933:16)
03:34:55 at defaultTriggerAsyncIdScope (internal/async_hooks.js:294:19)
03:34:55 at GetAddrInfoReqWrap.emitLookup [as callback] (net.js:1080:9)
03:34:55 at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:62:10)
03:34:55 Emitted 'error' event at:
03:34:55 at Socket.socketErrorListener (_http_client.js:399:9)
03:34:55 at Socket.emit (events.js:182:13)
03:34:55 at emitErrorNT (internal/streams/destroy.js:82:8)
03:34:55 at emitErrorAndCloseNT (internal/streams/destroy.js:50:3)
03:34:55 at process._tickCallback (internal/process/next_tick.js:63:19)
03:34:55 ...

[BridgeAR]

I just had a look at this one and I opened a PR as fix.