Investigate flaky pummel/test-heapdump-worker

[Trott]

https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5409/console

test-rackspace-ubuntu1604-x64-1

00:05:38 not ok 76 pummel/test-heapdump-worker
00:05:38 ---
00:05:38 duration_ms: 2.617
00:05:38 severity: fail
00:05:38 exitcode: 1
00:05:38 stack: |-
00:05:38 /home/iojs/build/workspace/node-test-commit-custom-suites-freestyle/test/common/heap.js:67
00:05:38 throw new Error(
00:05:38 ^
00:05:38 
00:05:38 Error: expected to find child { node_name: 'Node / AsyncRequest',
00:05:38 edge_name: 'thread_stopper_' } in [ { type: 'native',
00:05:38 name: 'Node / Worker',
00:05:38 id: 148476736,
00:05:38 self_size: 264,
00:05:38 edge_count: 3,
00:05:38 trace_node_id: 0,
00:05:38 incomingEdges:
00:05:38 [ { type: 'element',
00:05:38 to: [Circular],
00:05:38 from:
00:05:38 { type: 'synthetic',
00:05:38 name: '',
00:05:38 id: 1,
00:05:38 self_size: 0,
00:05:38 edge_count: 6,
00:05:38 trace_node_id: 0,
00:05:38 incomingEdges: [],
00:05:38 outgoingEdges: [Array] },
00:05:38 name: null },
00:05:38 { type: 'internal',
00:05:38 to: [Circular],
00:05:38 from:
00:05:38 { type: 'object',
00:05:38 name: 'Worker',
00:05:38 id: 60087,
00:05:38 self_size: 32,
00:05:38 edge_count: 6,
00:05:38 trace_node_id: 0,
00:05:38 incomingEdges: [Array],
00:05:38 outgoingEdges: [Array] },
00:05:38 name: 'wrapper' } ],
00:05:38 outgoingEdges:
00:05:38 [ { type: 'internal',
00:05:38 to:
00:05:38 { type: 'object',
00:05:38 name: 'Worker',
00:05:38 id: 60087,
00:05:38 self_size: 32,
00:05:38 edge_count: 6,
00:05:38 trace_node_id: 0,
00:05:38 incomingEdges: [Array],
00:05:38 outgoingEdges: [Array] },
00:05:38 from: [Circular],
00:05:38 name: 'wrapped' },
00:05:38 { type: 'internal',
00:05:38 to:
00:05:38 { type: 'native',
00:05:38 name: 'Node / MessagePort',
00:05:38 id: 158403648,
00:05:38 self_size: 216,
00:05:38 edge_count: 2,
00:05:38 trace_node_id: 0,
00:05:38 incomingEdges: [Array],
00:05:38 outgoingEdges: [Array] },
00:05:38 from: [Circular],
00:05:38 name: 'parent_port' },
00:05:38 { type: 'internal',
00:05:38 to:
00:05:38 { type: 'native',
00:05:38 name: 'Node / AsyncRequest',
00:05:38 id: 158402304,
00:05:38 self_size: 72,
00:05:38 edge_count: 1,
00:05:38 trace_node_id: 0,
00:05:38 incomingEdges: [Array],
00:05:38 outgoingEdges: [Array] },
00:05:38 from: [Circular],
00:05:38 name: 'on_thread_finished_' } ] } ]
00:05:38 at State.validateSnapshot (/home/iojs/build/workspace/node-test-commit-custom-suites-freestyle/test/common/heap.js:67:19)
00:05:38 at State.validateSnapshotNodes (/home/iojs/build/workspace/node-test-commit-custom-suites-freestyle/test/common/heap.js:113:10)
00:05:38 at validateSnapshotNodes (/home/iojs/build/workspace/node-test-commit-custom-suites-freestyle/test/common/heap.js:123:24)
00:05:38 at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-custom-suites-freestyle/test/pummel/test-heapdump-worker.js:9:1)
00:05:38 at Module._compile (internal/modules/cjs/loader.js:813:30)
00:05:38 at Object.Module._extensions..js (internal/modules/cjs/loader.js:824:10)
00:05:38 at Module.load (internal/modules/cjs/loader.js:680:32)
00:05:38 at tryModuleLoad (internal/modules/cjs/loader.js:612:12)
00:05:38 at Function.Module._load (internal/modules/cjs/loader.js:604:3)
00:05:38 at Function.Module.runMain (internal/modules/cjs/loader.js:876:12)
00:05:38 ...

[addaleax]

I think the test is broken, not just flaky, since #21283. A fix is in #26713.

I’d still be a fan of running pummel tests as part of the regular CI, just maybe not on every machine.

[gireeshpunathil]

Apologies. I used to run this test as part of #26099 development, but missed when resumed work on #21283 .

[addaleax]

Yeah, I think this one is on our CI setup and not on you ¯\_(ツ)_/¯