deps: regression in openssl

[yanovich]

Version

18.1.0

Platform

Linux host2 5.15.0-25-generic #25-Ubuntu SMP Wed Mar 30 15:54:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Subsystem

openssl

What steps will reproduce the bug?

build a simple addon

How often does it reproduce? Is there a required condition?

always

What is the expected behavior?

addon is built

What do you see instead?

$ yarn build 
yarn run v1.22.18
$ node-gyp configure --silent && node-gyp build --silent
make: Entering directory '/home/user/src/addon/build'
 CXX(target) Release/obj.target/addon/addon.o
In file included from /home/s/.cache/node-gyp/18.1.0/include/node/openssl/opensslconf.h:9,
 from /home/s/.cache/node-gyp/18.1.0/include/node/openssl/macros.h:14,
 from /home/s/.cache/node-gyp/18.1.0/include/node/openssl/evp.h:14,
 from ../addon.cc:5:
/home/s/.cache/node-gyp/18.1.0/include/node/openssl/./opensslconf_asm.h:97:11: fatal error: ./archs/linux-x86_64/asm/include/openssl/opensslconf.h: No such file or directory
 97 | # include "./archs/linux-x86_64/asm/include/openssl/opensslconf.h"
 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [addon.target.mk:120: Release/obj.target/addon/addon.o] Error 1
$ head -n 5 addon.cc
#include <stdlib.h>
#include <string.h>
#include <iostream>

#include <openssl/evp.h>

Additional information

commit 7fae2c9 breaks C++ addons which use any openssl header

[yanovich]

#42616

[mscdex]

I can duplicate this.

/cc @danbev

[danbev]

I'll open a PR to revert that commit.

[mmomtchev]

I think that it is time for at least a basic addon building unit test - 18.1.0 is seriously broken because of this

[BethGriggs]

Hope to ship the fix in a Node.js 18 release this week (as long as we do not hit any unexpected problems/delays).

[bnoordhuis]

Closing, this was fixed months ago by #42978.