Case-sensitive algorithm argument in crypto.createVerify()

[jhermsmeier]

Contrary to what can be seen & read in the documentation,

const verify = crypto.createVerify('rsa-sha256');

crypto.createVerify() throws if the algorithm argument is lowercase:

crypto.js:295
 this._handle.init(algorithm);
 ^

Error: Unknown message digest
 at Error (native)
 at new Verify (crypto.js:295:16)
 at Object.Verify (crypto.js:292:12)

It works perfectly fine if the algorithm is uppercased. Is this intended behavior (and the documentation just needs updating) or is this indeed a minor bug?

[bnoordhuis]

Strictly speaking it's the documentation that is wrong. The official openssl name is either RSA-SHA256 or sha256WithRSAEncryption and is case-sensitive.

We could add a crypto.getHashes().filter(s => RegExp(name, 'i').test(s)) step for convenience but I'd worry it introduce problems down the line.

[jhermsmeier]

Ah, interesting. But wouldn't just uppercasing the passed in algorithm argument fix the issue without causing problems anywhere else?

[bnoordhuis]

Unfortunately not. If you uppercase e.g. sha256WithRSAEncryption, openssl won't recognize it.

[raineroviir]

I've created a pull request which corrects this issue in the documentation
#5044

[jhermsmeier]

Cool, thanks!