assert.deepEqual is broken?

[mohayonao]

• Node: v5.9.1
• Platform: Darwin 15.4.0 Darwin Kernel Version 15.4.0: Fri Feb 26 22:08:05 PST 2016; root:xnu-3248.40.184~3/RELEASE_X86_64 x86_64

Problem:
Does not throw an exception, when comparing two Float32Array which have the small different values.

assert.deepEqual(new Float32Array([ 0 ]), new Float32Array([ 0.1 ]));
// undefined (This does not throw an AssertionError?)

This works as expected.

assert.deepEqual(new Float32Array([ 0 ]), new Float32Array([ 1 ]));
// AssertionError: Float32Array { '0': 0 } deepEqual Float32Array { '0': 1 }
// at repl:1:8
// at REPLServer.defaultEval (repl.js:260:27)
// at bound (domain.js:287:14)
// at REPLServer.runBound [as eval] (domain.js:300:12)
// at REPLServer.<anonymous> (repl.js:429:12)
// at emitOne (events.js:95:20)
// at REPLServer.emit (events.js:182:7)
// at REPLServer.Interface._onLine (readline.js:211:10)
// at REPLServer.Interface._line (readline.js:550:8)
// at REPLServer.Interface._ttyWrite (readline.js:827:14)

[addaleax]

This happens due to this line, where typed arrays are converted to Buffer objects entry-for-entry, i.e. each entry in the source becomes one uint8 in the Buffer. This is not specific to floats:

assert.deepEqual(new Float32Array([ 0 ]), new Float32Array([ 255 ])) // throws
assert.deepEqual(new Float32Array([ 0 ]), new Float32Array([ 256 ])) // passes, 256 becomes 0x00
assert.deepEqual(new Float32Array([ 0 ]), new Float32Array([ 257 ])) // throws

Same with Uint16Array etc.
I’ll see whether I can get a fix together.