Skip to content

Compiler warnings on quic/streams.cc #60110

Description

@targos
[4376/4521] CXX obj/src/quic/libnode.streams.o
../../src/quic/streams.cc:842:13: warning: comparison of integers of different signs: 'stream_id' (aka 'long long') and 'const size_t' (aka 'const unsigned long') [-Wsign-compare]
842 | DCHECK(id < kMaxStreamId);
| ~~ ^ ~~~~~~~~~~~~
../../src/util.h:195:30: note: expanded from macro 'DCHECK'
195 | #define DCHECK(expr) CHECK(expr)
| ^~~~
../../src/util.h:179:11: note: expanded from macro 'CHECK'
179 | if (!(expr)) [[unlikely]] { \
| ^~~~
../../src/quic/streams.cc:899:13: warning: comparison of integers of different signs: 'stream_id' (aka 'long long') and 'const size_t' (aka 'const unsigned long') [-Wsign-compare]
899 | DCHECK(id < kMaxStreamId);
| ~~ ^ ~~~~~~~~~~~~
../../src/util.h:195:30: note: expanded from macro 'DCHECK'
195 | #define DCHECK(expr) CHECK(expr)
| ^~~~
../../src/util.h:179:11: note: expanded from macro 'CHECK'
179 | if (!(expr)) [[unlikely]] { \
| ^~~~
2 warnings generated.

@nodejs/quic

Metadata

Metadata

Assignees

No one assigned

    Labels

    quicIssues and PRs related to the QUIC implementation / HTTP/3.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions