Path.format doesn't concat .name and .ext

[eight04]

• Version: v4.4.3
• Platform: Windows 7 64-bit
• Subsystem: path

https://nodejs.org/docs/v4.4.3/api/path.html#path_path_format_pathobject

Under path.format, the document said that:

If the base property is not supplied, a concatenation of the name property and the ext property will be used as the base property.

However, This feature seems not working properly. With following code:

var path = require("path");

var file = path.format({
 root : "C:\\",
 dir : "C:\\path\\dir",
 ext : ".txt",
 name : "file"
});

console.log(file);

I always get:

C:\path\dir\

[mscdex]

It works for me in v5.10.1 and v6.0.0. Looks like something may need to be backported?

[nwoltman]

For some reason the docs were backported but the code wasn't.

The PR that introduced that functionality is #2408. That PR has the semver-major label so that's why it was never backported. Also, after @mscdex re-wrote the path module, a lot of commits were never backported. Those are being tracked in this issue.

So either something needs to be backported or the doc changes need to be reverted in the v4.x branch.

[jasnell]

Odd... the doc change may have been picked up along with some other doc updates and just overlooked. The right thing to do would be to revert the doc change in the v4.x.

[MylesBorins]

+1 on reverting doc change. Does anyone know the shas?

[nwoltman]

I think these are all of them: daf3ef6, 0943001 (contains other changes), 79d26ae, aed22d0

bf1fe46 also changes the path.format docs and was made after 0943001 but it should be kept since it has nothing to do with the changed functionality.

[MylesBorins]

I have submitted a change to revert the docs. Thanks for reporting @eight04

[imyller]

Closing this issue as resolved with PR #6530