Skip to content

test: refactor test-dgram-msgsize.js - #10032

Closed
dguo wants to merge 1 commit into
nodejs:masterfrom
dguo:test-dgram-msgsize-refactor
Closed

test: refactor test-dgram-msgsize.js#10032
dguo wants to merge 1 commit into
nodejs:masterfrom
dguo:test-dgram-msgsize-refactor

Conversation

@dguo

@dguodguo commented Dec 1, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Change var to const, and change assert.equal() to assert.strictEqual().

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@imyllerimyller added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. dgram Issues and PRs related to the dgram subsystem / UDP. labels Dec 1, 2016
@mcollina

Copy link
Copy Markdown
Member

@mcollina

Copy link
Copy Markdown
Member

Failure unrelated. Merging.

@mcollina

Copy link
Copy Markdown
Member

Impossible to merge, the same changes are part of #9926.

@mcollinamcollina closed this Dec 6, 2016
@Trott

Trott commented Dec 7, 2016

Copy link
Copy Markdown
Member

Sorry about giving you a duplicate task! I see that you got a few other PRs open from Code & Learn, so that's a relief. :-D

Anyway, this was my mistake, so I apologize!

@dguo

dguo commented Dec 7, 2016

Copy link
Copy Markdown
ContributorAuthor

Oh, it's no problem. Thanks for MCing the event! It was fun.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.dgramIssues and PRs related to the dgram subsystem / UDP.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@dguo@mcollina@Trott@jasnell@cjihrig@imyller@nodejs-github-bot