Uh oh!
There was an error while loading. Please reload this page.
Test fix - fix to /test/parallel/test-cluster - #10047
Closed
navulirs wants to merge 2 commits into
Closed
Conversation
37:5 error please use assert.strictEqual() instead of assert.equal() 39:5 error please use assert.strictEqual() instead of assert.equal()
10.5 error Please use assert.strictEqual() instead of assert.equal()
cjihrig
reviewed
Dec 3, 2016
| @@ -34,8 +34,8 @@ cat.on('exit', common.mustCall(function(status) { | |||
Contributor
There was a problem hiding this comment.
There are two assert.ok() calls in this file that would be better off as strictEqual() calls.
Trott
commented
Dec 8, 2016
Member
italoacasas
commented
Dec 14, 2016
ping @sriluvan |
navulirs
commented
Dec 16, 2016
ContributorAuthor
Hi.sorry for late response. Attending this now. |
Trott
commented
Dec 22, 2016
Member
This one looks like it changes |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 22, 2016
10.5 error Please use assert.strictEqual() instead of assert.equal() PR-URL: nodejs#10047 Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
commented
Dec 22, 2016
Member
Landed in 72c773c. |
evanlucas pushed a commit
that referenced
this pull request
Jan 3, 2017
10.5 error Please use assert.strictEqual() instead of assert.equal() PR-URL: #10047 Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit
that referenced
this pull request
Jan 4, 2017
10.5 error Please use assert.strictEqual() instead of assert.equal() PR-URL: #10047 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jan 23, 2017
10.5 error Please use assert.strictEqual() instead of assert.equal() PR-URL: #10047 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jan 24, 2017
10.5 error Please use assert.strictEqual() instead of assert.equal() PR-URL: #10047 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Jan 31, 2017
10.5 error Please use assert.strictEqual() instead of assert.equal() PR-URL: #10047 Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
10:5 error Please use assert.strictEqual() instead of assert.strictEqual()