fs: re-enable watch facility in AIX by gireeshpunathil · Pull Request #10085 · nodejs/node

gireeshpunathil · 2016-12-02T06:03:31Z

Checklist

make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

fs

Description of change

Please refer to 5085 for a full description of the background, need for this PR, and the changes.

On AIX, watch feature depends on AHAFS based Event infrastructure.
While in principle the watch use case is same across platforms, there
are subtle differences in the way AIX deals with this, with few
behavioral changes (external).

This commit addresses an assertion failure on folder watch, enabling the
AIX code for watch feature which was masked under a macro, open up
relevant test cases, skip tests which comes under the AIX limitation,
and make the document changes as appropriate.

Trott · 2016-12-02T13:26:06Z

I am excited to see the AIX exceptions removed from parallel.status. Thanks for doing this!

The JS test code change looks good to me. The text in the paragraph added to the doc needs some editing. Maybe someone from @nodejs/documentation can take a look and provide a reformatted version.

Trott · 2016-12-02T13:27:07Z

Oh, I see there are changes in deps/uv. I suspect those would need to be upstreamed to the libuv project. (Do we float patches on libuv?)

bnoordhuis · 2016-12-02T14:28:35Z

Do we float patches on libuv?

No.

gireeshpunathil · 2016-12-02T14:47:40Z

@Trott , @bnoordhuis , thanks. So what is the recommendation here? first have a PR for the uv change, and then come back here with the rest of the changes? or progress this PMR and schedule the uv PR before the next libuv release separately? sorry for being blunt here, I don't know the process much.

bnoordhuis · 2016-12-02T14:51:19Z

@gireeshpunathil libuv PR -> libuv release -> libuv upgrade in node -> node PR -> node release. You can file the node PR ahead of time but it can't land until the libuv upgrade.

gireeshpunathil · 2016-12-02T15:02:42Z

ok, got it. will work on the libuv PR, to follow the sequence.

mhdawson

LGTM

thefourtheye · 2017-02-08T02:34:18Z

Suggest rewording just a bit...
Moreover, save and close operations on some platforms cause inode changes that force watch operations to become invalid and ineffective.

jasnell

One nit but otherwise LGTM

On AIX, watch feature depends on AHAFS based Event infrastructure. While in principle the watch use case is same across platforms, there are subtle differences in the way AIX deals with this, with few behavioral changes (external). This commit addresses an assertion failure on folder watch, enabling the AIX code for watch feature which was masked under a macro, open up relevant test cases, skip tests which comes under the AIX limitation, and make the document changes as appropriate.

gireeshpunathil · 2017-02-09T05:06:49Z

made the doc changes as per @jasnell . @thefourtheye - thanks, your change proposal is indirectly addressed, as the entire sentence is now modified.

thefourtheye

@gireeshpunathil Thanks :-)

cjihrig

LGTM. CI before landing: https://ci.nodejs.org/job/node-test-pull-request/6318/

cjihrig · 2017-02-09T18:56:56Z

Landed in 46edd94. Thanks!

On AIX, watch feature depends on AHAFS based Event infrastructure. While in principle the watch use case is same across platforms, there are subtle differences in the way AIX deals with this, with few behavioral changes (external). This commit addresses an assertion failure on folder watch, enabling the AIX code for watch feature which was masked under a macro, open up relevant test cases, skip tests which comes under the AIX limitation, and make the document changes as appropriate. Refs: #11094 Refs: #5085 PR-URL: #10085 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

gireeshpunathil · 2017-02-10T05:51:06Z

thanks everyone!

On AIX, watch feature depends on AHAFS based Event infrastructure. While in principle the watch use case is same across platforms, there are subtle differences in the way AIX deals with this, with few behavioral changes (external). This commit addresses an assertion failure on folder watch, enabling the AIX code for watch feature which was masked under a macro, open up relevant test cases, skip tests which comes under the AIX limitation, and make the document changes as appropriate. Refs: #11094 Refs: #5085 PR-URL: #10085 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

On AIX, watch feature depends on AHAFS based Event infrastructure. While in principle the watch use case is same across platforms, there are subtle differences in the way AIX deals with this, with few behavioral changes (external). This commit addresses an assertion failure on folder watch, enabling the AIX code for watch feature which was masked under a macro, open up relevant test cases, skip tests which comes under the AIX limitation, and make the document changes as appropriate. Refs: nodejs#11094 Refs: nodejs#5085 PR-URL: nodejs#10085 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

jasnell · 2017-03-07T18:53:40Z

should this land in v6 or v4?

gireeshpunathil · 2017-03-08T08:16:48Z

I guess no, as this PR depends on aix: re-enable fs watch facility from libuv 1.11.0, which v6 and v4 haven't consumed.

gireeshpunathil · 2017-03-08T08:24:37Z

@jasnell - ok, I see your question to LTS in 11094 as well. So answer here will depend on that decision.

On AIX, watch feature depends on AHAFS based Event infrastructure. While in principle the watch use case is same across platforms, there are subtle differences in the way AIX deals with this, with few behavioral changes (external). This commit addresses an assertion failure on folder watch, enabling the AIX code for watch feature which was masked under a macro, open up relevant test cases, skip tests which comes under the AIX limitation, and make the document changes as appropriate. Refs: #11094 Refs: #5085 PR-URL: #10085 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

On AIX, watch feature depends on AHAFS based Event infrastructure. While in principle the watch use case is same across platforms, there are subtle differences in the way AIX deals with this, with few behavioral changes (external). This commit addresses an assertion failure on folder watch, enabling the AIX code for watch feature which was masked under a macro, open up relevant test cases, skip tests which comes under the AIX limitation, and make the document changes as appropriate. Refs: nodejs/node#11094 Refs: nodejs/node#5085 PR-URL: nodejs/node#10085 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

nodejs-github-bot added the libuv Issues and PRs related to the libuv dependency or the uv binding. label Dec 2, 2016

gireeshpunathil mentioned this pull request Dec 3, 2016
fs: re-enable watch facility in AIX libuv/libuv#1156
Closed

mscdex added the aix Issues and PRs related to the AIX platform. label Dec 3, 2016

gireeshpunathil mentioned this pull request Feb 7, 2017
deps: upgrade libuv to 1.11.0 #11094
Closed
2 tasks

mhdawson approved these changes Feb 7, 2017
View reviewed changes

thefourtheye reviewed Feb 8, 2017
View reviewed changes

jasnell approved these changes Feb 8, 2017
View reviewed changes

thefourtheye approved these changes Feb 9, 2017
View reviewed changes

santigimeno approved these changes Feb 9, 2017
View reviewed changes

cjihrig approved these changes Feb 9, 2017
View reviewed changes

cjihrig closed this Feb 9, 2017

italoacasas mentioned this pull request Feb 13, 2017
Proposal - 7.6.0 (Current) #11185
Merged

MylesBorins added the backport-requested-v6.x label Apr 17, 2017

MylesBorins mentioned this pull request May 16, 2017
failures on aix v6.x-staging nodejs/Release#218
Closed

MylesBorins added land-on-v6.x and removed backport-requested-v6.x labels May 16, 2017

MylesBorins mentioned this pull request May 23, 2017
v6.11.0 proposal #13059
Merged

Uh oh!

Uh oh!

Conversation

gireeshpunathil commented Dec 2, 2016• edited by Fishrock123 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Affected core subsystem(s)

Description of change

Uh oh!

Trott commented Dec 2, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented Dec 2, 2016

Uh oh!

bnoordhuis commented Dec 2, 2016

Uh oh!

gireeshpunathil commented Dec 2, 2016

Uh oh!

bnoordhuis commented Dec 2, 2016

Uh oh!

gireeshpunathil commented Dec 2, 2016

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

thefourtheyeFeb 8, 2017

Choose a reason for hiding this comment

Uh oh!

jasnellFeb 8, 2017

Choose a reason for hiding this comment

Uh oh!

jasnell left a comment

Choose a reason for hiding this comment

Uh oh!

gireeshpunathil commented Feb 9, 2017

Uh oh!

thefourtheye left a comment

Choose a reason for hiding this comment

Uh oh!

cjihrig left a comment

Choose a reason for hiding this comment

Uh oh!

cjihrig commented Feb 9, 2017

Uh oh!

gireeshpunathil commented Feb 10, 2017

Uh oh!

jasnell commented Mar 7, 2017

Uh oh!

gireeshpunathil commented Mar 8, 2017

Uh oh!

gireeshpunathil commented Mar 8, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

gireeshpunathil commented Dec 2, 2016•
edited by Fishrock123
Loading

Trott commented Dec 2, 2016•
edited
Loading