Uh oh!
There was an error while loading. Please reload this page.
url: improve parsing speed - #102
Conversation
The url.parse() function now checks whether an escapable character is in the URL before trying to escape it. PR-URL: nodejs/node-v0.x-archive#8638 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Based on the ad-hoc benchmark from nodejs/node-v0.x-archive#8638.
indutny
commented
Dec 8, 2014
Please tag it, @caineio |
bnoordhuis
commented
Dec 9, 2014
@chrisdickinson Maybe you can review b7fc957? That one can go in without having to wait for the OPR (original pull requester; yes, I made that up on the spot.) |
chrisdickinson
commented
Dec 9, 2014
@bnoordhuis done and done. Had one request + a italicized verdant hope for a v8 feature, otherwise b7fc957 looks good. |
Based on the ad-hoc benchmark from nodejs/node-v0.x-archive#8638 plus an additional benchmark for user:pass auth URLs. PR-URL: #102 Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
bnoordhuis
commented
Dec 9, 2014
Cheers Chris, incorporated the feedback and landed in 21a679a.
I suppose doing a few url.parse() trial runs, then calling |
bnoordhuis
commented
Jan 6, 2015
Closing, this landed by way of the joyent/v0.12 merge in 94e1475. |
The url.parse() function now checks whether an escapable character is
in the URL before trying to escape it.
PR-URL: nodejs/node-v0.x-archive#8638
@CGavrila Would you be willing to sign the commit with your real name?