Skip to content

doc: document R CRAN mirror process - #10211

Closed
lholmquist wants to merge 1 commit into
nodejs:masterfrom
lholmquist:benchmark-doc-r-10204
Closed

doc: document R CRAN mirror process#10211
lholmquist wants to merge 1 commit into
nodejs:masterfrom
lholmquist:benchmark-doc-r-10204

Conversation

@lholmquist

@lholmquistlholmquist commented Dec 10, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • [x ] documentation is changed or added
  • [ x] commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

The current benchmark docs showing how to install R packages
doesn't go into how to specify a CRAN mirror.

This PR adds 3 options on how to install the needed packages
when a CRAN mirror is asked for.

fixes: #10204

@nodejs-github-botnodejs-github-bot added dont-land-on-v7.x benchmark Issues and PRs related to the benchmark subsystem. labels Dec 10, 2016
@lholmquistlholmquist mentioned this pull request Dec 10, 2016
Closed
@AndreasMadsen

AndreasMadsen commented Dec 10, 2016

Copy link
Copy Markdown
Member

I would prefer just a single safe option, I think half a page of install instructions is kinda scary for the reader.

$ R
options(menu.graphics = FALSE)
install.packages("ggplot2")
install.packages("plyr")

or

$ R
install.packages("ggplot2", repo="http://cran.us.r-project.org")
install.packages("plyr", repo="http://cran.us.r-project.org")

should be sufficient.

@lholmquist

lholmquist commented Dec 12, 2016

Copy link
Copy Markdown
ContributorAuthor

@AndreasMadsen yea, that makes sense, i'll probably use the second option

@lholmquist

lholmquist commented Dec 12, 2016

Copy link
Copy Markdown
ContributorAuthor

@AndreasMadsen ok, updated and rebased

@AndreasMadsen

AndreasMadsen commented Dec 12, 2016

Copy link
Copy Markdown
Member

LGTM. To be clear you should get that message on all platforms, but some may show it as an X11 window, which is what causes the problems.

@lholmquist

lholmquist commented Dec 12, 2016

Copy link
Copy Markdown
ContributorAuthor

@AndreasMadsen should i change the heading then? or leave as is?

@AndreasMadsenAndreasMadsen added the doc Issues and PRs related to the documentations. label Dec 12, 2016
@AndreasMadsen

AndreasMadsen commented Dec 12, 2016

Copy link
Copy Markdown
Member

@lholmquist You could change it to CRAN mirror or something similar.

@lholmquist

lholmquist commented Dec 12, 2016

Copy link
Copy Markdown
ContributorAuthor

@AndreasMadsen ok, updated and rebased

lance
lance reviewed Dec 13, 2016
View reviewed changes
Comment threadbenchmark/README.md Outdated

@lancelanceDec 13, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: 'suits your location'

@lholmquistlholmquistDec 13, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@lholmquist
doc: document R CRAN mirror process
fa5643c
The current benchmark docs showing how to install R packages
doesn't go into how to specify a CRAN mirror.
This commit shows how to specify the repo parameter when
installing a package.
fixes: nodejs#10204
@lance

lance commented Dec 15, 2016

Copy link
Copy Markdown
Member

Landed in: eceef76

@lancelance closed this Dec 15, 2016
lance pushed a commit that referenced this pull request Dec 15, 2016
@lholmquist@lance
doc: document R CRAN mirror process
eceef76
The current benchmark docs showing how to install R packages
doesn't go into how to specify a CRAN mirror.
This commit shows how to specify the repo parameter when
installing a package.
Fixes: #10204
PR-URL: #10211
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
italoacasas pushed a commit that referenced this pull request Dec 17, 2016
@lholmquistItalo A. Casas
doc: document R CRAN mirror process
6b98906
The current benchmark docs showing how to install R packages
doesn't go into how to specify a CRAN mirror.
This commit shows how to specify the repo parameter when
installing a package.
Fixes: #10204
PR-URL: #10211
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
@italoacasasitaloacasas mentioned this pull request Dec 17, 2016
Merged
cjihrig pushed a commit that referenced this pull request Dec 20, 2016
@lholmquist@cjihrig
doc: document R CRAN mirror process
6ca5e5f
The current benchmark docs showing how to install R packages
doesn't go into how to specify a CRAN mirror.
This commit shows how to specify the repo parameter when
installing a package.
Fixes: #10204
PR-URL: #10211
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
@MylesBorins

MylesBorins commented Jan 22, 2017

Copy link
Copy Markdown
Contributor

This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport

@AndreasMadsen

AndreasMadsen commented Jan 23, 2017

Copy link
Copy Markdown
Member

It should not be backported, the entire benchmark suite was rewritten in v7 and declared a major change.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@lancelancelance left review comments
@AndreasMadsenAndreasMadsenAndreasMadsen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

benchmarkIssues and PRs related to the benchmark subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Benchmark docs: how to select the CRAN Mirror for R

5 participants

@lholmquist@AndreasMadsen@lance@MylesBorins@nodejs-github-bot