Uh oh!
There was an error while loading. Please reload this page.
fs: remove needless assignment of null - #10260
Closed
reconbot wants to merge 1 commit into
Closed
Conversation
addaleax
commented
Dec 13, 2016
Member
Looks good but could you edit the commit message & PR title so that it starts with |
This line `pool = null;` isn't needed and has been around since the first iteration of streams. I can't find a good reason for it to exist, it's not more readable, nor does it seem to trick the compiler into any optimizations.
MylesBorins
commented
Dec 14, 2016
Contributor
/cc @nodejs/streams |
addaleax
approved these changes
Dec 14, 2016
addaleax
left a comment
Member
There was a problem hiding this comment.
LGTM
(contrary to popular belief, this is not a streams change :P)
mcollina
approved these changes
Dec 14, 2016
mcollina
left a comment
Member
There was a problem hiding this comment.
LGTM even it it is not a stream change :D.
reconbot
commented
Dec 18, 2016
ContributorAuthor
Is there a @nodejs/fs group to cc? |
gibfahn
commented
Dec 18, 2016
Member
cc/ @nodejs/fs |
cjihrig
approved these changes
Dec 18, 2016
cjihrig
left a comment
Contributor
There was a problem hiding this comment.
Seems straightforward. The first thing allocNewPool() does is assign pool a new value.
italoacasas
approved these changes
Dec 19, 2016
italoacasas
commented
Dec 20, 2016
Landed 1081f0f |
cjihrig pushed a commit
to cjihrig/node
that referenced
this pull request
Dec 20, 2016
This line `pool = null;` isn't needed and has been around since the first iteration of streams. I can't find a good reason for it to exist, it's not more readable, nor does it seem to trick the compiler into any optimizations. PR-URL: nodejs#10260 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
Merged
cjihrig pushed a commit
that referenced
this pull request
Dec 20, 2016
This line `pool = null;` isn't needed and has been around since the first iteration of streams. I can't find a good reason for it to exist, it's not more readable, nor does it seem to trick the compiler into any optimizations. PR-URL: #10260 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins pushed a commit
that referenced
this pull request
Jan 23, 2017
This line `pool = null;` isn't needed and has been around since the first iteration of streams. I can't find a good reason for it to exist, it's not more readable, nor does it seem to trick the compiler into any optimizations. PR-URL: #10260 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins pushed a commit
that referenced
this pull request
Jan 24, 2017
This line `pool = null;` isn't needed and has been around since the first iteration of streams. I can't find a good reason for it to exist, it's not more readable, nor does it seem to trick the compiler into any optimizations. PR-URL: #10260 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Jan 31, 2017
This line `pool = null;` isn't needed and has been around since the first iteration of streams. I can't find a good reason for it to exist, it's not more readable, nor does it seem to trick the compiler into any optimizations. PR-URL: #10260 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
streams
Description of change
This line
pool = null;isn't needed and has been around since the first iteration offs.stream. I can't find a good reason for it to exist, it's not more readable, nor does it seem to trick the compiler into any optimizations.