Uh oh!
There was an error while loading. Please reload this page.
test: add known_issues test for #5350 - #10319
Conversation
Fishrock123
commented
Dec 17, 2016
@AnnaMag btw, to get the list to show up as a checklist you need to remove the white space. :D e.g. |
Fishrock123
left a comment
There was a problem hiding this comment.
I think make lintshould catch those nits? I forget.
There was a problem hiding this comment.
Is this the proper way to write it?'this.hasOwnProperty("propBase");'
I thought that double quotes are used in JS to avoid escaping: http://standardjs.com/rules.html
Could you clarify this for me, please? Thanks!
There was a problem hiding this comment.
Oh uh... good question. We don't use Standard though (for legacy reasons).
@Trott thoughts? I'd prefer template strings tbh but I think our linter may warn about that currently...
There was a problem hiding this comment.
Ok. I asked for future reference.
I used template strings here: https://github.com/nodejs/node/pull/10272/files
and looks like the linter was ok with it
There was a problem hiding this comment.
In our lint rules, double quotes are acceptable if being used to avoid escaping single quotes. There are a few examples of it in the code base, but not many.
There was a problem hiding this comment.
(Just providing the answer to the question asked. I'm fine with whatever you do in this case as long as the linter accepts it.)
There was a problem hiding this comment.
could we drop the trailing comma?
cc/ @fhinkel From https://nodejs.org/api/vm.html#vm_vm_createcontext_sandbox |
b9b9655 to
559dcadCompareThere was a problem hiding this comment.
Can you use camelCase for JavaScript variables please.
559dcad to
f829fb7Comparef829fb7 to
9c9c5a7CompareAnnaMag
commented
Dec 17, 2016
@Fishrock123, @cjihrig Done- thanks! |
| @@ -0,0 +1,20 @@ | |||
| 'use strict'; | |||
| // Ref: https://github.com/nodejs/node/issues/5350 | |||
There was a problem hiding this comment.
We usually don't include Ref: when linking to issues. I can only find two tests that do that. (For consistency they probably shouldn't)
There was a problem hiding this comment.
I don't think it matters.
The more information possible the better, though.
There was a problem hiding this comment.
I meant just get rid of Ref, not the link.
There was a problem hiding this comment.
Yea. I meant the known issue tests (I think all of them) include Refs: at the top.
There was a problem hiding this comment.
Never mind. Didn't realize that's the standard for known tests. Sorry for derailing the discussion.
AnnaMag
commented
Dec 20, 2016
Yes, it seems to be included in all files in that dir. I assumed it was an agreed upon "standard". Of course, np to remove it. |
italoacasas
commented
Dec 21, 2016
Landed: b73402d |
PR-URL: #10319 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
PR-URL: #10319 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
PR-URL: #10319 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
this passes on v6 and fails on v4. Landed only on v6 |
PR-URL: #10319 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
PR-URL: #10319 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
tests
Description of change
A test addressing subproblem of #5350
inherited properties flattened in the vm.runInNewContextis added to the known_issues directory.
It will be fixed with the 5.5 V8 API changes
#5350 is a consequence of the above as flattening of sandbox
inherited properties happens first inside the vm context
and is subsequently translated onto the outer sandbox.
assert.strictEqual(sandbox.hasOwnProperty('propBase'), false);