Uh oh!
There was an error while loading. Please reload this page.
test: refactor test-stdin-from-file - #10331
Closed
radelmann wants to merge 1 commit into
Closed
Conversation
cjihrig
approved these changes
Dec 19, 2016
italoacasas
approved these changes
Dec 19, 2016
Remove console.log statement. Replace error check with assert.ifError().
radelmannforce-pushed
the
test-stdin-from-file.js
branch
from
December 19, 2016 18:01
9fceb7d to
f34f8c1Comparelpinca
approved these changes
Dec 19, 2016
radelmann
commented
Dec 22, 2016
ContributorAuthor
bump |
jasnell
approved these changes
Dec 23, 2016
jasnell
commented
Dec 23, 2016
Member
italoacasas
commented
Dec 29, 2016
@jasnell are u going to land this ? |
jasnell
commented
Dec 29, 2016
Member
Yeah, have just been catching up on things.. appreciate the ping! |
jasnell pushed a commit
that referenced
this pull request
Dec 29, 2016
Remove console.log statement. Replace error check with assert.ifError(). PR-URL: #10331 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
commented
Dec 29, 2016
Member
Landed in 407c1ad |
evanlucas pushed a commit
that referenced
this pull request
Jan 3, 2017
Remove console.log statement. Replace error check with assert.ifError(). PR-URL: #10331 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit
that referenced
this pull request
Jan 4, 2017
Remove console.log statement. Replace error check with assert.ifError(). PR-URL: #10331 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jan 23, 2017
Remove console.log statement. Replace error check with assert.ifError(). PR-URL: #10331 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jan 23, 2017
Remove console.log statement. Replace error check with assert.ifError(). PR-URL: #10331 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jan 24, 2017
Remove console.log statement. Replace error check with assert.ifError(). PR-URL: #10331 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jan 24, 2017
Remove console.log statement. Replace error check with assert.ifError(). PR-URL: #10331 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jan 31, 2017
Remove console.log statement. Replace error check with assert.ifError(). PR-URL: #10331 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Feb 1, 2017
Remove console.log statement. Replace error check with assert.ifError(). PR-URL: #10331 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test
Description of change
console.log()statement.assert.ifError().