Skip to content

test: improve code in test-vm-preserves-property - #10428

Closed
edsadr wants to merge 1 commit into
nodejs:masterfrom
edsadr:vm-preserves-property
Closed

test: improve code in test-vm-preserves-property#10428
edsadr wants to merge 1 commit into
nodejs:masterfrom
edsadr:vm-preserves-property

Conversation

@edsadr

@edsadredsadr commented Dec 23, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change
  • use const instead of var
  • use assert.strictEqual instead assert.equal

@edsadr
test: improve code in test-vm-preserves-property
2df5c76
* use const instead of var
* use assert.strictEqual instead assert.equal
@nodejs-github-botnodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Dec 23, 2016
@mscdexmscdex added the vm Issues and PRs related to the vm subsystem. label Dec 23, 2016
@lpinca

lpinca commented Dec 26, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5585/

@lpinca

lpinca commented Dec 26, 2016

Copy link
Copy Markdown
Member

Landed in 89c8f58.

@lpincalpinca closed this Dec 26, 2016
lpinca pushed a commit that referenced this pull request Dec 26, 2016
@edsadr@lpinca
test: improve code in test-vm-preserves-property
89c8f58
* use const instead of var
* use assert.strictEqual instead assert.equal
PR-URL #10428
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@evanlucasevanlucas mentioned this pull request Jan 3, 2017
Merged
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
@edsadr@evanlucas
test: improve code in test-vm-preserves-property
b905e99
* use const instead of var
* use assert.strictEqual instead assert.equal
PR-URL #10428
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
@edsadr@evanlucas
test: improve code in test-vm-preserves-property
98fcb22
* use const instead of var
* use assert.strictEqual instead assert.equal
PR-URL #10428
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@edsadr@MylesBorins
test: improve code in test-vm-preserves-property
6a6dda7
* use const instead of var
* use assert.strictEqual instead assert.equal
PR-URL #10428
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@edsadr@MylesBorins
test: improve code in test-vm-preserves-property
f99c4f5
* use const instead of var
* use assert.strictEqual instead assert.equal
PR-URL #10428
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@edsadr@MylesBorins
test: improve code in test-vm-preserves-property
2a26a31
* use const instead of var
* use assert.strictEqual instead assert.equal
PR-URL #10428
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@edsadr@MylesBorins
test: improve code in test-vm-preserves-property
6818454
* use const instead of var
* use assert.strictEqual instead assert.equal
PR-URL #10428
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@edsadr@MylesBorins
test: improve code in test-vm-preserves-property
6bc34d2
* use const instead of var
* use assert.strictEqual instead assert.equal
PR-URL #10428
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Jan 24, 2017
Merged
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
@edsadr@MylesBorins
test: improve code in test-vm-preserves-property
c5ccffd
* use const instead of var
* use assert.strictEqual instead assert.equal
PR-URL #10428
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
@edsadr@MylesBorins
test: improve code in test-vm-preserves-property
56b193a
* use const instead of var
* use assert.strictEqual instead assert.equal
PR-URL #10428
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

testIssues and PRs related to the tests.vmIssues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@edsadr@lpinca@jasnell@cjihrig@mscdex@MylesBorins@nodejs-github-bot