Uh oh!
There was an error while loading. Please reload this page.
test: increase coverage of Buffer.transcode - #10437
Closed
joyeecheung wants to merge 1 commit into
Closed
Conversation
Adds test for transcoding an empty buffer.
Trott
commented
Dec 24, 2016
Member
targos
approved these changes
Dec 24, 2016
cjihrig
approved these changes
Dec 24, 2016
jasnell
approved these changes
Dec 24, 2016
jasnell pushed a commit
that referenced
this pull request
Dec 24, 2016
Adds test for transcoding an empty buffer. PR-URL: #10437 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
commented
Dec 24, 2016
Member
Landed in 904b66d |
italoacasas pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
Adds test for transcoding an empty buffer. PR-URL: nodejs#10437 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jan 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, buffer
Description of change
Adds test for transcoding an empty buffer.