Skip to content

test: improve the code in test-pipe.js - #10452

Closed
edsadr wants to merge 1 commit into
nodejs:masterfrom
edsadr:test-pipe
Closed

test: improve the code in test-pipe.js#10452
edsadr wants to merge 1 commit into
nodejs:masterfrom
edsadr:test-pipe

Conversation

@edsadr

@edsadredsadr commented Dec 25, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change
  • use const and let instead of var
  • use common.mustCall to control functions executions
  • use assert.strictEqual instead of assert.equal
  • use assert.ifError to handle errors
  • use arrow functions

@nodejs-github-botnodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Dec 25, 2016
mscdex
mscdex reviewed Dec 25, 2016
View reviewed changes
Comment threadtest/sequential/test-pipe.js Outdated

@mscdexmscdexDec 25, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove these log statements too? Also the process.stdout.write() statements.

mscdex
mscdex reviewed Dec 25, 2016
View reviewed changes
Comment threadtest/sequential/test-pipe.js Outdated

@mscdexmscdexDec 25, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be removed now that we're asserting.

@mscdexmscdex added http Issues or PRs related to the http subsystem. net Issues and PRs related to the net subsystem. labels Dec 25, 2016
@edsadr

edsadr commented Dec 25, 2016

Copy link
Copy Markdown
ContributorAuthor

@mscdex, changed as suggested

@mscdex

mscdex commented Dec 25, 2016

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/5582/

@mscdex

mscdex commented Dec 26, 2016

Copy link
Copy Markdown
Contributor

LGTM

lpinca
lpinca reviewed Dec 26, 2016
View reviewed changes
Comment threadtest/sequential/test-pipe.js Outdated

@lpincalpincaDec 26, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: how about wrapping this listener with common.mustCall and remove the gotThanks flag?

@edsadredsadrDec 27, 2016•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lpinca the problem adding the common.mustCall for this event, is that we are not sure about the exact number of times this function will be called, every time the test run the number could be different, so adding it will make the test to fail sporadically

@lpincalpincaDec 27, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edsadr there is an assertion which basically check that the listener is called once.

assert.strictEqual('thanks',string);

If the are multiple chunks then the assertion fails anyway.

@edsadr
test: improve the code in test-pipe.js
448d193
* use const and let instead of var
* use common.mustCall to control functions executions
* use assert.strictEqual instead of assert.equal
* use assert.ifError to handle errors
* use arrow functions
* remove console.log and process.stdout.write
@edsadr

edsadr commented Dec 27, 2016

Copy link
Copy Markdown
ContributorAuthor

@lpinca , I stand corrected I was checking the other event:

s.on('data',(d)=>{tcpLengthSeen+=d.length;for(letj=0;j<d.length;j++){assert.strictEqual(buffer[i],d[j]);i++;}});

That one is the one being called multiple times, just fixed the one you suggested and I guess just left to set the CI

@lpinca

lpinca commented Dec 27, 2016

Copy link
Copy Markdown
Member

New CI: https://ci.nodejs.org/job/node-test-pull-request/5597/

@italoacasas

italoacasas commented Dec 27, 2016

Copy link
Copy Markdown

Landed fc103bb

@evanlucasevanlucas mentioned this pull request Jan 3, 2017
Merged
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
@edsadr@evanlucas
test: improve the code in test-pipe.js
783f987
* use const and let instead of var
* use common.mustCall to control functions executions
* use assert.strictEqual instead of assert.equal
* use assert.ifError to handle errors
* use arrow functions
* remove console.log and process.stdout.write
PR-URL: #10452
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
@edsadr@evanlucas
test: improve the code in test-pipe.js
f6ed233
* use const and let instead of var
* use common.mustCall to control functions executions
* use assert.strictEqual instead of assert.equal
* use assert.ifError to handle errors
* use arrow functions
* remove console.log and process.stdout.write
PR-URL: #10452
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@edsadr@MylesBorins
test: improve the code in test-pipe.js
731aeb4
* use const and let instead of var
* use common.mustCall to control functions executions
* use assert.strictEqual instead of assert.equal
* use assert.ifError to handle errors
* use arrow functions
* remove console.log and process.stdout.write
PR-URL: #10452
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@edsadr@MylesBorins
test: improve the code in test-pipe.js
7059543
* use const and let instead of var
* use common.mustCall to control functions executions
* use assert.strictEqual instead of assert.equal
* use assert.ifError to handle errors
* use arrow functions
* remove console.log and process.stdout.write
PR-URL: #10452
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@edsadr@MylesBorins
test: improve the code in test-pipe.js
5a1de80
* use const and let instead of var
* use common.mustCall to control functions executions
* use assert.strictEqual instead of assert.equal
* use assert.ifError to handle errors
* use arrow functions
* remove console.log and process.stdout.write
PR-URL: #10452
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@edsadr@MylesBorins
test: improve the code in test-pipe.js
f1f34df
* use const and let instead of var
* use common.mustCall to control functions executions
* use assert.strictEqual instead of assert.equal
* use assert.ifError to handle errors
* use arrow functions
* remove console.log and process.stdout.write
PR-URL: #10452
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
This was referenced Jan 24, 2017
Merged
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
@edsadr@MylesBorins
test: improve the code in test-pipe.js
d2ce390
* use const and let instead of var
* use common.mustCall to control functions executions
* use assert.strictEqual instead of assert.equal
* use assert.ifError to handle errors
* use arrow functions
* remove console.log and process.stdout.write
PR-URL: #10452
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
@edsadr@MylesBorins
test: improve the code in test-pipe.js
31aa877
* use const and let instead of var
* use common.mustCall to control functions executions
* use assert.strictEqual instead of assert.equal
* use assert.ifError to handle errors
* use arrow functions
* remove console.log and process.stdout.write
PR-URL: #10452
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@jasnelljasnelljasnell approved these changes
+1 more reviewer
@mscdexmscdexmscdex left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

httpIssues or PRs related to the http subsystem.netIssues and PRs related to the net subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@edsadr@mscdex@lpinca@italoacasas@jasnell@MylesBorins@nodejs-github-bot