Uh oh!
There was an error while loading. Please reload this page.
v6.x: backport test: fix test-buffer-slow - #10459
Merged
Merged
Conversation
targos
commented
Dec 26, 2016
MemberAuthor
Fix incorrect use of string instead of RegExp in `throws` assertions. PR-URL: nodejs#9809 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targosforce-pushed
the
backport-9809-v6.x
branch
from
December 26, 2016 13:10
13e8cfe to
70d3b80Comparetargos
commented
Dec 26, 2016
MemberAuthor
CI failed because I cherry-picked #10146 instead of #10149 before making the PR. |
targos
commented
Dec 26, 2016
MemberAuthor
landed in 70d3b80 |
This was referenced Apr 24, 2023
This was referenced Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9809