Uh oh!
There was an error while loading. Please reload this page.
doc: new TLSSocket has no secure context options - #10545
Closed
sam-github wants to merge 1 commit into
Closed
Conversation
Unlike all the other tls APIs, if any secure context configuration is required, the caller is responsible for creating the context. Corrects a doc regression introduced in caa7fa9. Fixnodejs#10538
sam-githubforce-pushed
the
tlssocket-ctx-correction
branch
from
December 30, 2016 17:18
e7b7b55 to
ee6421eComparenbdd0121
commented
Dec 31, 2016
I believe that what describes in the doc is sensible. Maybe we should change the implementation instead? |
sam-github
commented
Dec 31, 2016
ContributorAuthor
First we doc it how it is, because it can't be changed in existing releases, changing would be semver major. Then we can propose changing it for 8.x. And people will understand the change, because they will see the doc change, and be able to compare old behaviour to new. |
sam-github
commented
Jan 3, 2017
ContributorAuthor
PTAL @nodejs/documentation @nodejs/crypto |
benjamingr
approved these changes
Jan 3, 2017
benjamingr
commented
Jan 3, 2017
Member
Change LGTM, but I also find the behavior slightly confusing. |
sam-github
commented
Jan 3, 2017
ContributorAuthor
I agree, and I'm working on a PR to make the ctor pass its options to |
jasnell
approved these changes
Jan 5, 2017
jasnell
commented
Jan 5, 2017
Member
@nodejs/crypto |
addaleax
commented
Jan 6, 2017
Member
Maybe it’s better to leave the |
addaleax
approved these changes
Jan 6, 2017
jasnell pushed a commit
that referenced
this pull request
Jan 6, 2017
Unlike all the other tls APIs, if any secure context configuration is required, the caller is responsible for creating the context. Corrects a doc regression introduced in caa7fa9. PR-URL: #10545 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell
commented
Jan 6, 2017
Member
italoacasas pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
Unlike all the other tls APIs, if any secure context configuration is required, the caller is responsible for creating the context. Corrects a doc regression introduced in caa7fa9. PR-URL: nodejs#10545 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
italoacasas pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 19, 2017
Unlike all the other tls APIs, if any secure context configuration is required, the caller is responsible for creating the context. Corrects a doc regression introduced in caa7fa9. PR-URL: nodejs#10545 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
italoacasas pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 24, 2017
Unlike all the other tls APIs, if any secure context configuration is required, the caller is responsible for creating the context. Corrects a doc regression introduced in caa7fa9. PR-URL: nodejs#10545 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
italoacasas pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
Unlike all the other tls APIs, if any secure context configuration is required, the caller is responsible for creating the context. Corrects a doc regression introduced in caa7fa9. PR-URL: nodejs#10545 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
MylesBorins
commented
Mar 7, 2017
Contributor
@sam-github should this be backported? If so please feel free to cherry-pick. If it doesn't land cleanly feel free to add |
sam-github
commented
Mar 8, 2017
ContributorAuthor
It should backport to 6.x to fix b662de6, but not needed on 4.x. I will do. |
MylesBorins pushed a commit
that referenced
this pull request
Apr 13, 2017
Unlike all the other tls APIs, if any secure context configuration is required, the caller is responsible for creating the context. Corrects a doc regression introduced in caa7fa9. PR-URL: #10545 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit
that referenced
this pull request
Apr 19, 2017
Unlike all the other tls APIs, if any secure context configuration is required, the caller is responsible for creating the context. Corrects a doc regression introduced in caa7fa9. PR-URL: #10545 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
andrew749 pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
Unlike all the other tls APIs, if any secure context configuration is required, the caller is responsible for creating the context. Corrects a doc regression introduced in caa7fa9. PR-URL: nodejs/node#10545 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike all the other tls APIs, if any secure context configuration is
required, the caller is responsible for creating the context.
Corrects a doc regression introduced in caa7fa9.
Fix#10538
Checklist
Affected core subsystem(s)
doc,tls