Skip to content

test: refactor of zlib-from-gzip-with-trailing-garbage - #10674

Closed
lfkwtz wants to merge 2 commits into
nodejs:masterfrom
lfkwtz:fix-trailing-garbage-tests
Closed

test: refactor of zlib-from-gzip-with-trailing-garbage#10674
lfkwtz wants to merge 2 commits into
nodejs:masterfrom
lfkwtz:fix-trailing-garbage-tests

Conversation

@lfkwtz

@lfkwtzlfkwtz commented Jan 7, 2017

Copy link
Copy Markdown
Contributor
  • use assert.strictEqual instead of assert.equal
  • add RegExp in second argument of assert.throws
  • removed unused arguments
Checklist
  • [ x ] commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Jan 7, 2017
@mscdexmscdex added the zlib Issues and PRs related to the zlib subsystem. label Jan 7, 2017
jasnell
jasnell reviewed Jan 7, 2017
View reviewed changes
Comment threadtest/parallel/test-zlib-from-gzip-with-trailing-garbage.js Outdated

@jasnelljasnellJan 7, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would likely be worthwhile validating the details of the error reported

@TrottTrottJan 7, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also recommend restoring result as an argument and adding an assertion for it. So all together, maybe something like this?:

assert(errinstanceofError);assert.strictEqual(err.code,'Z_DATA_ERROR');assert.strictEqual(err.message,'unknown compression method');assert.strictEqual(result,undefined);

@lfkwtzlfkwtzJan 7, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New commit pushed up with these suggestions included. Thanks to the both of you for the help. Long time listener, first time committer. 😄

jasnell
jasnell approved these changes Jan 7, 2017
View reviewed changes

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion

Trott
Trott reviewed Jan 7, 2017
View reviewed changes
Comment threadtest/parallel/test-zlib-from-gzip-with-trailing-garbage.js Outdated

@TrottTrottJan 7, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same suggestions here as above. Restore result, add an assertion to confirm it is undefined, and do some more rigorous checking on err.

@lfkwtz
test: refactor of zlib-from-gzip-with-trailing-garbage
5519d8e
* use assert.strictEqual instead of assert.equal
* add RegExp in second argument of assert.throws
* removed unused arguments
@lfkwtz
test: added addtl tests to zlib-from-gzip-with-trailing-garbage
d0cbf50
* restore result args and validate response
* validate error message and code
@jasnell

jasnell commented Jan 9, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5761/

@lfkwtz

lfkwtz commented Jan 9, 2017

Copy link
Copy Markdown
ContributorAuthor

@jasnell I see one test failed... any suggestion on how to fix this?

@lpinca

lpinca commented Jan 9, 2017

Copy link
Copy Markdown
Member

@leftynaut test/arm is marked as failed but it actually passed, you can see this if you click on details. CI is 100% green 🎉 .

@jbergstroem

jbergstroem commented Jan 9, 2017

Copy link
Copy Markdown
Member

@lpinca said:
@leftynaut test/arm is marked as failed but it actually passed, you can see this if you click on details. CI is 100% green 🎉 .

Bug here: nodejs/github-bot#108

Trott pushed a commit to Trott/io.js that referenced this pull request Jan 10, 2017
@lfkwtz@Trott
test: improve zlib-from-gzip-with-trailing-garbage
39c4af5
* use assert.strictEqual instead of assert.equal
* add RegExp in second argument of assert.throws
* validate error message and code
PR-URL: nodejs#10674
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott

Trott commented Jan 10, 2017

Copy link
Copy Markdown
Member

Landed in 39c4af5.
Thanks for the contribution! 🎉

@TrottTrott closed this Jan 10, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@lfkwtzItalo A. Casas
test: improve zlib-from-gzip-with-trailing-garbage
e1e1d3c
* use assert.strictEqual instead of assert.equal
* add RegExp in second argument of assert.throws
* validate error message and code
PR-URL: nodejs#10674
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
@lfkwtzItalo A. Casas
test: improve zlib-from-gzip-with-trailing-garbage
37bdf59
* use assert.strictEqual instead of assert.equal
* add RegExp in second argument of assert.throws
* validate error message and code
PR-URL: nodejs#10674
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 25, 2017
@lfkwtzItalo A. Casas
test: improve zlib-from-gzip-with-trailing-garbage
b530de4
* use assert.strictEqual instead of assert.equal
* add RegExp in second argument of assert.throws
* validate error message and code
PR-URL: nodejs#10674
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@italoacasasitaloacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@lfkwtzItalo A. Casas
test: improve zlib-from-gzip-with-trailing-garbage
cf5579d
* use assert.strictEqual instead of assert.equal
* add RegExp in second argument of assert.throws
* validate error message and code
PR-URL: nodejs#10674
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@italoacasasitaloacasas mentioned this pull request Jan 29, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
@lfkwtz@MylesBorins
test: improve zlib-from-gzip-with-trailing-garbage
d7df7c1
* use assert.strictEqual instead of assert.equal
* add RegExp in second argument of assert.throws
* validate error message and code
PR-URL: #10674
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@lfkwtz@MylesBorins
test: improve zlib-from-gzip-with-trailing-garbage
86e3936
* use assert.strictEqual instead of assert.equal
* add RegExp in second argument of assert.throws
* validate error message and code
PR-URL: #10674
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott left review comments
@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

testIssues and PRs related to the tests.zlibIssues and PRs related to the zlib subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@lfkwtz@jasnell@lpinca@jbergstroem@Trott@cjihrig@mscdex@MylesBorins@nodejs-github-bot